Skip to content

sonarqube checks #1094

@zacharyburnett

Description

@zacharyburnett

bugs found by sonar scan:
https://plsonarqube.stsci.edu/project/issues?resolved=false&types=BUG&id=spacetelescope-regresstiontests&open=AY1_N9SAz6SXJ5XqzbxH

  1. Remove or refactor this statement; it has no side effects.

    Should this be =?

  2. result.meta.cal_step.tweakreg == "SKIPPED"

    Remove or refactor this statement; it has no side effects.

    same as 1; should this be =?

  3. def __contains__(self, x, y):

    Remove 1 parameters. Method __contains__ should have 2 parameters.

    will this raise an error if a user calls in, even before the NotImplementedError?

  4. raise BigdataError(f"Path cannot be found: {path}")

    path is used before it is defined. Move the definition before.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions