-
Notifications
You must be signed in to change notification settings - Fork 31
Open
Labels
bugSomething isn't workingSomething isn't working
Description
bugs found by sonar scan:
https://plsonarqube.stsci.edu/project/issues?resolved=false&types=BUG&id=spacetelescope-regresstiontests&open=AY1_N9SAz6SXJ5XqzbxH
-
exp_type == "science" Remove or refactor this statement; it has no side effects.
Should this be
=
? -
result.meta.cal_step.tweakreg == "SKIPPED" Remove or refactor this statement; it has no side effects.
same as 1; should this be
=
? -
romancal/romancal/skymatch/region.py
Line 40 in 7a62ff3
def __contains__(self, x, y): Remove 1 parameters. Method
__contains__
should have 2 parameters.will this raise an error if a user calls
in
, even before theNotImplementedError
? -
romancal/romancal/tests/base_classes.py
Line 105 in 7a62ff3
raise BigdataError(f"Path cannot be found: {path}") path
is used before it is defined. Move the definition before.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working