Merge branch 'master' into add-network_interfaces_eni

xorima · web-flow · commit 75ce5572ad55 · 2020-11-20T19:41:01.000Z
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -0,0 +1,10 @@
+---
+version: 2.1
+orbs:
+  kitchen: sous-chefs/kitchen@2
+workflows:
+  danger:
+    jobs:
+      - kitchen/danger:
+          name: danger
+          context: Danger-Minimal
diff --git a/.editorconfig b/.editorconfig
@@ -0,0 +1,19 @@
+# https://EditorConfig.org
+
+# top-most EditorConfig file
+root=true
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+insert_final_newline = true
+
+# 2 space indentation
+indent_style = space
+indent_size = 2
+
+# Avoid issues parsing cookbook files later
+charset = utf-8
+
+# Avoid cookstyle warnings
+trim_trailing_whitespace = true
diff --git a/.envrc b/.envrc
@@ -0,0 +1 @@
+use chefworkstation
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1 @@
+* text=auto eol=lf
diff --git a/.github/workflows/md-links.yml b/.github/workflows/md-links.yml
@@ -0,0 +1,19 @@
+---
+name: md-links
+
+"on":
+  pull_request:
+  push:
+    branches: [master]
+
+jobs:
+  md-links:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code
+        uses: actions/checkout@master
+      - name: markdown-link-check
+        uses: gaurav-nelson/github-action-markdown-link-check@v1
+        with:
+          use-verbose-mode: "yes"
+          folder-path: "documentation"
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
@@ -0,0 +1,28 @@
+---
+name: Mark stale issues and pull requests
+
+"on":
+  schedule:
+    - cron: "0 0 * * *"
+
+jobs:
+  stale:
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/stale@v3
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          close-issue-message: >
+            Closing due to inactivity.
+            If this is still an issue please reopen or open another issue.
+            Alternatively drop by the #sous-chefs channel on the [Chef Community Slack](http://community-slack.chef.io/) and we'll be happy to help!
+            Thanks, Sous-Chefs.
+          days-before-close: 7
+          days-before-stale: 365
+          stale-issue-message: >
+            Marking stale due to inactivity.
+            Remove stale label or comment or this will be closed in 7 days.
+            Alternatively drop by the #sous-chefs channel on the [Chef Community Slack](http://community-slack.chef.io/) and we'll be happy to help!
+            Thanks, Sous-Chefs.
diff --git a/.gitignore b/.gitignore
@@ -1,23 +1,49 @@
+*.rbc
+.config
+InstalledFiles
+pkg
+test/tmp
+test/version_tmp
+tmp
+_Store
 *~
 *#
 .#*
 \#*#
-.*.sw[a-z]
 *.un~
 *.tmp
 *.bk
 *.bkup
-.kitchen.local.yml
-Berksfile.lock
+
+# editor files
+.idea
+.*.sw[a-z]
+
+# ruby/bundler/rspec files
+.ruby-version
+.ruby-gemset
+.rvmrc
 Gemfile.lock
+.bundle
+*.gem
+coverage
+spec/reports
 
-.bundle/
-.cache/
-.kitchen/
-.vagrant/
-.vagrant.d/
-.yardoc/
-bin/
+# YARD / rdoc artifacts
+.yardoc
+_yardoc
 doc/
-tmp/
+rdoc
+
+# chef infra stuff
+Berksfile.lock
+.kitchen
+kitchen.local.yml
 vendor/
+.coverage/
+.zero-knife.rb
+Policyfile.lock.json
+
+# vagrant stuff
+.vagrant/
+.vagrant.d/
diff --git a/.overcommit.yml b/.overcommit.yml
@@ -0,0 +1,20 @@
+---
+PreCommit:
+  TrailingWhitespace:
+    enabled: true
+  YamlLint:
+    enabled: true
+  Rspec:
+    enabled: true
+    required_executable: 'rspec'
+  Cookstyle:
+    enabled: true
+    required_executable: 'cookstyle'
+    command: ["cookstyle"]
+  Delivery:
+    enabled: true
+    required_executable: 'delivery'
+    flags: ['local', 'all']
+CommitMsg:
+  HardTabs:
+    enabled: true
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -0,0 +1,7 @@
+{
+  "recommendations": [
+      "chef-software.chef",
+      "rebornix.ruby",
+      "editorconfig.editorconfig"
+  ]
+}
diff --git a/.yamllint b/.yamllint
@@ -0,0 +1,7 @@
+---
+extends: default
+rules:
+  line-length:
+    max: 256
+    level: warning
+  document-start: disable
diff --git a/Berksfile b/Berksfile
@@ -1,4 +1,4 @@
-source 'https://supermarket.getchef.com'
+source 'https://supermarket.chef.io'
 
 metadata
 
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,18 @@
 network_interface
 =================
+## Unreleased
+
+- resolved cookstyle error: Berksfile:1:1 refactor: `ChefModernize/LegacyBerksfileSource`
+- resolved cookstyle error: libraries/matchers.rb:1:1 refactor: `ChefModernize/DefinesChefSpecMatchers`
+- resolved cookstyle error: metadata.rb:6:1 refactor: `ChefRedundantCode/LongDescriptionMetadata`
+- resolved cookstyle error: providers/default.rb:1:1 refactor: `ChefModernize/WhyRunSupportedTrue`
+- resolved cookstyle error: providers/default.rb:5:1 warning: `ChefDeprecations/UseInlineResourcesDefined`
+- resolved cookstyle error: providers/default.rb:8:8 warning: `ChefDeprecations/NodeSet`
+- resolved cookstyle error: recipes/default.rb:2:1 refactor: `ChefStyle/CommentFormat`
+- resolved cookstyle error: recipes/default.rb:8:1 refactor: `ChefStyle/CommentFormat`
+- resolved cookstyle error: recipes/default.rb:9:1 refactor: `ChefStyle/CommentFormat`
+- resolved cookstyle error: recipes/default.rb:25:6 warning: `ChefDeprecations/NodeSet`
+
 
 # Unreleased:
 
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md
@@ -0,0 +1,3 @@
+# Community Guidelines
+
+This project follows the Chef Community Guidelines <https://docs.chef.io/community_guidelines.html>
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -0,0 +1,4 @@
+# Contributing
+
+Please refer to
+[https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD](https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD)
diff --git a/Dangerfile b/Dangerfile
@@ -0,0 +1,47 @@
+# Reference: http://danger.systems/reference.html
+
+# A pull request summary is required. Add a description of the pull request purpose.
+# Changelog must be updated for each pull request that changes code.
+# Warnings will be issued for:
+#    Pull request with more than 400 lines of code changed
+#    Pull reqest that change more than 5 lines without test changes
+# Failures will be issued for:
+#    Pull request without summary
+#    Pull requests with code changes without changelog entry
+
+def code_changes?
+  code = %w(libraries attributes recipes resources files templates)
+  code.each do |location|
+    return true unless git.modified_files.grep(/#{location}/).empty?
+  end
+  false
+end
+
+def test_changes?
+  tests = %w(spec test kitchen.yml kitchen.dokken.yml)
+  tests.each do |location|
+    return true unless git.modified_files.grep(/#{location}/).empty?
+  end
+  false
+end
+
+failure 'Please provide a summary of your Pull Request.' if github.pr_body.length < 10
+
+warn 'This is a big Pull Request.' if git.lines_of_code > 400
+
+warn 'This is a Table Flip.' if git.lines_of_code > 2000
+
+# Require a CHANGELOG entry for non-test changes.
+if !git.modified_files.include?('CHANGELOG.md') && code_changes?
+  failure 'Please include a CHANGELOG entry.'
+end
+
+# Require Major Minor Patch version labels
+unless github.pr_labels.grep /minor|major|patch/i
+  warn 'Please add a release label to this pull request'
+end
+
+# A sanity check for tests.
+if git.lines_of_code > 5 && code_changes? && !test_changes?
+  warn 'This Pull Request is probably missing tests.'
+end
diff --git a/TESTING.md b/TESTING.md
@@ -0,0 +1,3 @@
+# Testing
+
+Please refer to [the community cookbook documentation on testing](https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD).
diff --git a/chefignore b/chefignore
diff --git a/documentation/.gitkeep b/documentation/.gitkeep
diff --git a/libraries/matchers.rb b/libraries/matchers.rb
diff --git a/metadata.rb b/metadata.rb
diff --git a/providers/default.rb b/providers/default.rb
diff --git a/recipes/default.rb b/recipes/default.rb
