Fix issue with iis_pool stop (#346)

Signed-off-by: Justin Schuhmann <jmschu02@gmail.com>

Author: EasyAsABC123

resources/pool.rb

@@ -206,17 +206,17 @@
 end
 
 action :start do
-  if !current_resource.runtime_version
+  if !current_resource.runtime_version && !running
     converge_by "Started Application Pool \"#{new_resource}\"" do
-      shell_out!("#{appcmd(node)} start apppool \"#{new_resource.name}\"") unless new_resource.running
+      shell_out!("#{appcmd(node)} start apppool \"#{new_resource.name}\"")
     end
   else
     Chef::Log.debug("#{new_resource} already running - nothing to do")
   end
 end
 
 action :stop do
-  if current_resource.runtime_version
+  if current_resource.runtime_version && running
     converge_by "Stopped Application Pool \"#{new_resource}\"" do
       shell_out!("#{appcmd(node)} stop apppool \"#{new_resource.name}\"")
     end
@@ -238,7 +238,7 @@
 action :recycle do
   if current_resource.runtime_version
     converge_by "Recycled Application Pool \"#{new_resource}\"" do
-      shell_out!("#{appcmd(node)} recycle APPPOOL \"#{new_resource.name}\"")
+      shell_out!("#{appcmd(node)} recycle APPPOOL \"#{new_resource.name}\"") if running
     end
   end
 end

test/cookbooks/test/recipes/pool.rb

@@ -26,7 +26,7 @@
 iis_pool 'myAppPool_v1_1' do
   runtime_version '2.0'
   pipeline_mode :Classic
-  action [:add, :config]
+  action [:add, :config, :stop]
 end
 
 iis_pool 'testapppool' do

test/integration/pool/controls/pool_spec.rb

@@ -12,7 +12,7 @@
 
 describe iis_pool('myAppPool_v1_1') do
   it { should exist }
-  it { should be_running }
+  its('state') { should eq 'Stopped' }
   its('managed_runtime_version') { should eq 'v2.0' }
   it { should have_name('myAppPool_v1_1') }
   it { should have_queue_length(1000) }

test/integration/pool/libraries/iis_pool.rb

@@ -110,7 +110,6 @@ def has_name?(pool_name)
   end
 
   def has_queue_length?(queue_length)
-    Log.info(iis_pool)
     iis_pool.nil? ? false : iis_pool[:queue_length] == queue_length
   end
 
@@ -160,7 +159,6 @@ def iis_pool(pool_name)
       pool_cpu = JSON.parse(cmd_cpu.stdout)
       pool_worker_processes = JSON.parse(cmd_worker_processes.stdout)
     rescue JSON::ParserError => _e
-      Log.info(cmd.stderr)
       return {}
     end