From c5638d6e312e926304590282a7e409f8e67df3ee Mon Sep 17 00:00:00 2001 From: Balakrishna Avulapati Date: Tue, 27 May 2025 20:36:49 +0530 Subject: [PATCH 1/5] chore: move clang-tidy config file to project directory clang-tidy when the config is not explicitly mentioned in the command looks for it in the project directory with the name `.clang-tidy`. And editors like VS Code recognizes the `.clang-tidy` file when code analysis is enabled. This is not a fix for a bug. This is just trying to make clang-tidy config and usage more visible. Signed-off-by: Balakrishna Avulapati --- cmake/common/targets/clang-tidy.config => .clang-tidy | 3 ++- cmake/common/targets/clang-tidy.cmake | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) rename cmake/common/targets/clang-tidy.config => .clang-tidy (62%) diff --git a/cmake/common/targets/clang-tidy.config b/.clang-tidy similarity index 62% rename from cmake/common/targets/clang-tidy.config rename to .clang-tidy index df702e505..be789d76f 100644 --- a/cmake/common/targets/clang-tidy.config +++ b/.clang-tidy @@ -1,7 +1,8 @@ --- # See https://clang.llvm.org/extra/clang-tidy/index.html # First disable all default checks (with -*) -Checks: '-*,bugprone-*,clang-analyzer-*,clang-diagnostic-*,modernize-*,concurrency-*,cppcoreguidelines-*,performance-*,portability-*,objc-*,misc-*,-misc-no-recursion,-bugprone-easily-swappable-parameters' +# Checks: '-*,bugprone-*,clang-analyzer-*,clang-diagnostic-*,modernize-*,concurrency-*,cppcoreguidelines-*,performance-*,portability-*,objc-*,misc-*,-misc-no-recursion,-bugprone-easily-swappable-parameters' +Checks: '-*,cppcoreguidelines-macro-usage' WarningsAsErrors: '*' HeaderFilterRegex: '' FormatStyle: none diff --git a/cmake/common/targets/clang-tidy.cmake b/cmake/common/targets/clang-tidy.cmake index b7ca85c83..ff79f4d5e 100644 --- a/cmake/common/targets/clang-tidy.cmake +++ b/cmake/common/targets/clang-tidy.cmake @@ -41,7 +41,6 @@ function(sourcemeta_target_clang_tidy) WORKING_DIRECTORY "${PROJECT_SOURCE_DIR}" VERBATIM COMMAND "${CLANG_TIDY_BIN}" -p "${PROJECT_BINARY_DIR}" - --config-file "${CLANG_TIDY_CONFIG}" ${SOURCEMETA_TARGET_CLANG_TIDY_FILES} COMMENT "Analyzing sources using ClangTidy") else() From 587aea57b3116de7d09579fa1ec71657c389ca2b Mon Sep 17 00:00:00 2001 From: Balakrishna Avulapati Date: Tue, 27 May 2025 20:41:25 +0530 Subject: [PATCH 2/5] revert changes to config Signed-off-by: Balakrishna Avulapati --- .clang-tidy | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index be789d76f..df702e505 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,8 +1,7 @@ --- # See https://clang.llvm.org/extra/clang-tidy/index.html # First disable all default checks (with -*) -# Checks: '-*,bugprone-*,clang-analyzer-*,clang-diagnostic-*,modernize-*,concurrency-*,cppcoreguidelines-*,performance-*,portability-*,objc-*,misc-*,-misc-no-recursion,-bugprone-easily-swappable-parameters' -Checks: '-*,cppcoreguidelines-macro-usage' +Checks: '-*,bugprone-*,clang-analyzer-*,clang-diagnostic-*,modernize-*,concurrency-*,cppcoreguidelines-*,performance-*,portability-*,objc-*,misc-*,-misc-no-recursion,-bugprone-easily-swappable-parameters' WarningsAsErrors: '*' HeaderFilterRegex: '' FormatStyle: none From 44095bbffc39a7e79c0951a7682e3d435becdc20 Mon Sep 17 00:00:00 2001 From: Balakrishna Avulapati Date: Tue, 27 May 2025 20:49:35 +0530 Subject: [PATCH 3/5] remove unused cmake variable Signed-off-by: Balakrishna Avulapati --- cmake/common/targets/clang-tidy.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/cmake/common/targets/clang-tidy.cmake b/cmake/common/targets/clang-tidy.cmake index ff79f4d5e..47756d042 100644 --- a/cmake/common/targets/clang-tidy.cmake +++ b/cmake/common/targets/clang-tidy.cmake @@ -35,7 +35,6 @@ function(sourcemeta_target_clang_tidy) file(GLOB_RECURSE SOURCEMETA_TARGET_CLANG_TIDY_FILES ${SOURCEMETA_TARGET_CLANG_TIDY_SOURCES}) - set(CLANG_TIDY_CONFIG "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/clang-tidy.config") if(CLANG_TIDY_BIN) add_custom_target(clang_tidy WORKING_DIRECTORY "${PROJECT_SOURCE_DIR}" From 57a3ec5d1c47e858066e8cc8fbaaf07912d0b3a5 Mon Sep 17 00:00:00 2001 From: Balakrishna Avulapati Date: Thu, 19 Jun 2025 21:17:23 +0530 Subject: [PATCH 4/5] keep the config file path specification even if it's default --- cmake/common/targets/clang-tidy.cmake | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmake/common/targets/clang-tidy.cmake b/cmake/common/targets/clang-tidy.cmake index 47756d042..7d3a70f1b 100644 --- a/cmake/common/targets/clang-tidy.cmake +++ b/cmake/common/targets/clang-tidy.cmake @@ -35,11 +35,14 @@ function(sourcemeta_target_clang_tidy) file(GLOB_RECURSE SOURCEMETA_TARGET_CLANG_TIDY_FILES ${SOURCEMETA_TARGET_CLANG_TIDY_SOURCES}) + set(CLANG_TIDY_CONFIG "${PROJECT_SOURCE_DIR}/.clang-tidy") + if(CLANG_TIDY_BIN) add_custom_target(clang_tidy WORKING_DIRECTORY "${PROJECT_SOURCE_DIR}" VERBATIM COMMAND "${CLANG_TIDY_BIN}" -p "${PROJECT_BINARY_DIR}" + --config-file "${CLANG_TIDY_CONFIG}" ${SOURCEMETA_TARGET_CLANG_TIDY_FILES} COMMENT "Analyzing sources using ClangTidy") else() From 3b528249932c64e928d3f8908c8e2c93d57934b7 Mon Sep 17 00:00:00 2001 From: Balakrishna Avulapati Date: Thu, 19 Jun 2025 21:32:50 +0530 Subject: [PATCH 5/5] Move clang-format file to project directory Signed-off-by: Balakrishna Avulapati --- cmake/common/targets/clang-format.config => .clang-format | 0 cmake/common/targets/clang-format.cmake | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename cmake/common/targets/clang-format.config => .clang-format (100%) diff --git a/cmake/common/targets/clang-format.config b/.clang-format similarity index 100% rename from cmake/common/targets/clang-format.config rename to .clang-format diff --git a/cmake/common/targets/clang-format.cmake b/cmake/common/targets/clang-format.cmake index ac8e83d5c..ce23eb7b2 100644 --- a/cmake/common/targets/clang-format.cmake +++ b/cmake/common/targets/clang-format.cmake @@ -14,7 +14,7 @@ function(sourcemeta_target_clang_format) file(GLOB_RECURSE SOURCEMETA_TARGET_CLANG_FORMAT_FILES ${SOURCEMETA_TARGET_CLANG_FORMAT_SOURCES}) - set(CLANG_FORMAT_CONFIG "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/clang-format.config") + set(CLANG_FORMAT_CONFIG "${PROJECT_SOURCE_DIR}/.clang-format") if(CLANG_FORMAT_BIN) add_custom_target(clang_format WORKING_DIRECTORY "${PROJECT_SOURCE_DIR}"