Skip to content

Commit ef8f620

Browse files
bavulapatijviotti
andauthored
style(clang-tidy): fix modernize-use-integer-sign-comparison checks (#1811)
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com> Co-authored-by: Juan Cruz Viotti <jv@jviotti.com>
1 parent 9bdc384 commit ef8f620

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

src/extension/alterschema/alterschema.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
#include <algorithm>
77
#include <cmath>
88
#include <iterator>
9+
#include <utility>
910
namespace sourcemeta::core {
1011
static auto
1112
contains_any(const Vocabularies &container,

src/extension/alterschema/canonicalizer/min_properties_covered_by_required.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ class MinPropertiesCoveredByRequired final : public SchemaTransformRule {
2626
schema.at("minProperties").is_integer() &&
2727
schema.defines("required") && schema.at("required").is_array() &&
2828
schema.at("required").unique() &&
29-
schema.at("required").size() >
30-
static_cast<std::uint64_t>(
31-
schema.at("minProperties").to_integer());
29+
std::cmp_greater(schema.at("required").size(),
30+
static_cast<std::uint64_t>(
31+
schema.at("minProperties").to_integer()));
3232
}
3333

3434
auto transform(JSON &schema) const -> void override {

src/extension/alterschema/linter/unsatisfiable_min_properties.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ class UnsatisfiableMinProperties final : public SchemaTransformRule {
2626
schema.at("minProperties").is_integer() &&
2727
schema.defines("required") && schema.at("required").is_array() &&
2828
schema.at("required").unique() &&
29-
schema.at("required").size() >=
30-
static_cast<std::uint64_t>(
31-
schema.at("minProperties").to_integer());
29+
std::cmp_greater_equal(schema.at("required").size(),
30+
static_cast<std::uint64_t>(
31+
schema.at("minProperties").to_integer()));
3232
}
3333

3434
auto transform(JSON &schema) const -> void override {

0 commit comments

Comments
 (0)