style(clang-tidy): fix modernize-pass-by-value checks (#1807)

Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>

Author: bavulapati

src/core/json/include/sourcemeta/core/json_error.h

@@ -70,16 +70,15 @@ class SOURCEMETA_CORE_JSON_EXPORT JSONParseIntegerLimitError
 class SOURCEMETA_CORE_JSON_EXPORT JSONFileParseError : public JSONParseError {
 public:
   /// Create a file parsing error
-  JSONFileParseError(const std::filesystem::path &path,
-                     const std::uint64_t line, const std::uint64_t column,
-                     std::string message)
-      : JSONParseError{line, column, std::move(message)}, path_{path} {}
+  JSONFileParseError(std::filesystem::path path, const std::uint64_t line,
+                     const std::uint64_t column, std::string message)
+      : JSONParseError{line, column, std::move(message)},
+        path_{std::move(path)} {}
 
   /// Create a file parsing error from a parse error
-  JSONFileParseError(const std::filesystem::path &path,
-                     const JSONParseError &parent)
+  JSONFileParseError(std::filesystem::path path, const JSONParseError &parent)
       : JSONParseError{parent.line(), parent.column(), parent.what()},
-        path_{path} {}
+        path_{std::move(path)} {}
 
   /// Get the file path of the error
   [[nodiscard]] auto path() const noexcept -> const std::filesystem::path & {

src/core/jsonpointer/include/sourcemeta/core/jsonpointer_subpointer_walker.h

@@ -52,7 +52,7 @@ template <typename PointerT> class GenericSubPointerIterator {
 template <typename PointerT> class GenericSubPointerWalker {
 public:
   using const_iterator = GenericSubPointerIterator<PointerT>;
-  GenericSubPointerWalker(const PointerT &pointer) : data{pointer} {}
+  GenericSubPointerWalker(PointerT pointer) : data{std::move(pointer)} {}
 
   const_iterator begin() { return {&this->data}; }
   const_iterator end() { return {nullptr}; }

src/core/jsonpointer/include/sourcemeta/core/jsonpointer_token.h

@@ -17,9 +17,9 @@ template <typename PropertyT, typename Hash> class GenericToken {
   /// This constructor creates an JSON Pointer token from a string given its
   /// precomputed hash. This is advanced functionality that should be used with
   /// care.
-  GenericToken(const Property &value,
-               const typename Hash::hash_type property_hash)
-      : as_property{true}, property{value}, hash{property_hash}, index{0} {}
+  GenericToken(Property value, const typename Hash::hash_type property_hash)
+      : as_property{true}, property{std::move(value)}, hash{property_hash},
+        index{0} {}
 
   /// This constructor creates an JSON Pointer token from a string. For
   /// example:

src/core/jsonschema/include/sourcemeta/core/jsonschema_error.h

@@ -79,9 +79,10 @@ class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaVocabularyError
 class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaReferenceError
     : public std::exception {
 public:
-  SchemaReferenceError(std::string identifier, const Pointer &schema_location,
+  SchemaReferenceError(std::string identifier, Pointer schema_location,
                        std::string message)
-      : identifier_{std::move(identifier)}, schema_location_{schema_location},
+      : identifier_{std::move(identifier)},
+        schema_location_{std::move(schema_location)},
         message_{std::move(message)} {}
   [[nodiscard]] auto what() const noexcept -> const char * override {
     return this->message_.c_str();

src/core/jsonschema/include/sourcemeta/core/jsonschema_resolver.h

@@ -46,7 +46,7 @@ class SOURCEMETA_CORE_JSONSCHEMA_EXPORT SchemaMapResolver {
   SchemaMapResolver();
 
   /// Construct an empty resolver that has another schema resolver as a fallback
-  SchemaMapResolver(const SchemaResolver &resolver);
+  SchemaMapResolver(SchemaResolver resolver);
 
   /// Register a schema to the map resolver. Returns whether at least one
   /// schema was imported into the resolver

src/core/jsonschema/resolver.cc

@@ -7,8 +7,8 @@ namespace sourcemeta::core {
 
 SchemaMapResolver::SchemaMapResolver() = default;
 
-SchemaMapResolver::SchemaMapResolver(const SchemaResolver &resolver)
-    : default_resolver{resolver} {}
+SchemaMapResolver::SchemaMapResolver(SchemaResolver resolver)
+    : default_resolver{std::move(resolver)} {}
 
 auto SchemaMapResolver::add(
     const JSON &schema, const std::optional<std::string> &default_dialect,