style(clang-tidy): fix performance-move-const-arg (#1787)

bavulapati · web-flow · commit dbdb655c960a · 2025-06-26T09:51:10.000-04:00
Signed-off-by: Balakrishna Avulapati &lt;ba@bavulapati.com&gt;
diff --git a/src/core/json/json_value.cc b/src/core/json/json_value.cc
@@ -806,7 +806,7 @@ auto JSON::assign(const JSON::String &key, const JSON &value) -> void {
 
 auto JSON::assign(const JSON::String &key, JSON &&value) -> void {
   assert(this->is_object());
-  this->data_object.data.emplace(key, std::move(value));
+  this->data_object.data.emplace(key, value);
 }
 
 auto JSON::assign_if_missing(const JSON::String &key, const JSON &value)

Original file line number	Diff line number	Diff line change
`@@ -806,7 +806,7 @@ auto JSON::assign(const JSON::String &key, const JSON &value) -> void {`
`806`	`806`
`807`	`807`	`auto JSON::assign(const JSON::String &key, JSON &&value) -> void {`
`808`	`808`	`assert(this->is_object());`
`809`		`- this->data_object.data.emplace(key, std::move(value));`
	`809`	`+ this->data_object.data.emplace(key, value);`
`810`	`810`	`}`
`811`	`811`
`812`	`812`	`auto JSON::assign_if_missing(const JSON::String &key, const JSON &value)`