Test transformers that remove identifiers (#1644)

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

Author: jviotti

test/jsonschema/jsonschema_transform_rules.h

@@ -314,4 +314,28 @@ class ExampleRuleDefinitionsToDefsWithRereference final
   }
 };
 
+class ExampleRuleRemoveIdentifiers final
+    : public sourcemeta::core::SchemaTransformRule {
+public:
+  ExampleRuleRemoveIdentifiers()
+      : sourcemeta::core::SchemaTransformRule("example_rule_remove_identifiers",
+                                              "Remove all identifiers") {};
+
+  [[nodiscard]] auto condition(const sourcemeta::core::JSON &schema,
+                               const sourcemeta::core::JSON &,
+                               const sourcemeta::core::Vocabularies &,
+                               const sourcemeta::core::SchemaFrame &,
+                               const sourcemeta::core::SchemaFrame::Location &,
+                               const sourcemeta::core::SchemaWalker &,
+                               const sourcemeta::core::SchemaResolver &) const
+      -> sourcemeta::core::SchemaTransformRule::Result override {
+    return schema.is_object() &&
+           (schema.defines("$id") || schema.defines("$anchor"));
+  }
+
+  auto transform(sourcemeta::core::JSON &schema) const -> void override {
+    schema.erase_keys({"$id", "$anchor"});
+  }
+};
+
 #endif

test/jsonschema/jsonschema_transformer_test.cc

@@ -747,7 +747,7 @@ TEST(JSONSchema_transformer, rereference_not_hit) {
   EXPECT_EQ(document, expected);
 }
 
-TEST(JSONSchema_transformer, rereference_not_fixed) {
+TEST(JSONSchema_transformer, rereference_not_fixed_ref) {
   sourcemeta::core::SchemaTransformer bundle;
   bundle.add<ExampleRuleDefinitionsToDefsNoRereference>();
 
@@ -791,6 +791,79 @@ TEST(JSONSchema_transformer, rereference_not_fixed) {
   EXPECT_EQ(document, expected);
 }
 
+TEST(JSONSchema_transformer, rereference_not_fixed_id) {
+  sourcemeta::core::SchemaTransformer bundle;
+  bundle.add<ExampleRuleRemoveIdentifiers>();
+
+  sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "$id": "https://example.com",
+    "$ref": "helper",
+    "$defs": {
+      "helper": {
+        "$id": "helper"
+      }
+    }
+  })JSON");
+
+  TestTransformTraces entries;
+  const bool result =
+      bundle.apply(document, sourcemeta::core::schema_official_walker,
+                   sourcemeta::core::schema_official_resolver,
+                   transformer_callback_trace(entries));
+
+  EXPECT_TRUE(result);
+  EXPECT_EQ(entries.size(), 0);
+
+  // The reference is now just treated as an external one
+
+  const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "$ref": "helper",
+    "$defs": {
+      "helper": {}
+    }
+  })JSON");
+
+  EXPECT_EQ(document, expected);
+}
+
+TEST(JSONSchema_transformer, rereference_not_fixed_anchor) {
+  sourcemeta::core::SchemaTransformer bundle;
+  bundle.add<ExampleRuleRemoveIdentifiers>();
+
+  sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "$ref": "#helper",
+    "$defs": {
+      "helper": {
+        "$anchor": "helper"
+      }
+    }
+  })JSON");
+
+  TestTransformTraces entries;
+  const bool result =
+      bundle.apply(document, sourcemeta::core::schema_official_walker,
+                   sourcemeta::core::schema_official_resolver,
+                   transformer_callback_trace(entries));
+
+  EXPECT_TRUE(result);
+  EXPECT_EQ(entries.size(), 0);
+
+  // The reference is now just treated as an external one
+
+  const sourcemeta::core::JSON expected = sourcemeta::core::parse_json(R"JSON({
+    "$schema": "https://json-schema.org/draft/2020-12/schema",
+    "$ref": "#helper",
+    "$defs": {
+      "helper": {}
+    }
+  })JSON");
+
+  EXPECT_EQ(document, expected);
+}
+
 TEST(JSONSchema_transformer, rereference_fixed_1) {
   sourcemeta::core::SchemaTransformer bundle;
   bundle.add<ExampleRuleDefinitionsToDefsWithRereference>();