style(clang-tidy): fix bugprone-exception-escape (#1763)

bavulapati · web-flow · commit 663ce75d76b0 · 2025-06-24T08:30:13.000-04:00
Two reports were about struct. We are suppressing them for now. Let's
revisit when it creates noice on actual functions.

Signed-off-by: Balakrishna Avulapati &lt;ba@bavulapati.com&gt;
diff --git a/src/core/jsonschema/frame.cc b/src/core/jsonschema/frame.cc
@@ -222,6 +222,8 @@ auto store(
   instances[pointer_from_root] = instance_locations;
 }
 
+// Check misunderstood struct to be a function
+// NOLINTNEXTLINE(bugprone-exception-escape)
 struct InternalEntry {
   const sourcemeta::core::SchemaIteratorEntry common;
   const std::optional<sourcemeta::core::JSON::String> id;
@@ -257,6 +259,8 @@ auto traverse_origin_instance_locations(
   }
 }
 
+// Check misunderstood struct to be a function
+// NOLINTNEXTLINE(bugprone-exception-escape)
 struct CacheSubschema {
   const sourcemeta::core::PointerTemplate instance_location{};
   const sourcemeta::core::PointerTemplate relative_instance_location{};

Original file line number	Diff line number	Diff line change
`@@ -222,6 +222,8 @@ auto store(`
`222`	`222`	`instances[pointer_from_root] = instance_locations;`
`223`	`223`	`}`
`224`	`224`
	`225`	`+// Check misunderstood struct to be a function`
	`226`	`+// NOLINTNEXTLINE(bugprone-exception-escape)`
`225`	`227`	`struct InternalEntry {`
`226`	`228`	`const sourcemeta::core::SchemaIteratorEntry common;`
`227`	`229`	`const std::optional<sourcemeta::core::JSON::String> id;`
`@@ -257,6 +259,8 @@ auto traverse_origin_instance_locations(`
`257`	`259`	`}`
`258`	`260`	`}`
`259`	`261`
	`262`	`+// Check misunderstood struct to be a function`
	`263`	`+// NOLINTNEXTLINE(bugprone-exception-escape)`
`260`	`264`	`struct CacheSubschema {`
`261`	`265`	`const sourcemeta::core::PointerTemplate instance_location{};`
`262`	`266`	`const sourcemeta::core::PointerTemplate relative_instance_location{};`