From 2fdcc657518338e34cedf51eb1e77046bc8eb57f Mon Sep 17 00:00:00 2001
From: Camden Cheek <camden@ccheek.com>
Date: Wed, 1 Nov 2023 11:33:29 -0600
Subject: [PATCH 1/2] optimize fetching last file commit

---
 cmd/frontend/graphqlbackend/git_commits.go | 26 +++++++++++++++-------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/cmd/frontend/graphqlbackend/git_commits.go b/cmd/frontend/graphqlbackend/git_commits.go
index 79e512b5c06..7ee4adb33e3 100644
--- a/cmd/frontend/graphqlbackend/git_commits.go
+++ b/cmd/frontend/graphqlbackend/git_commits.go
@@ -10,6 +10,7 @@ import (
 	"github.com/sourcegraph/sourcegraph/internal/gitserver"
 	"github.com/sourcegraph/sourcegraph/internal/gitserver/gitdomain"
 	"github.com/sourcegraph/sourcegraph/lib/errors"
+	"github.com/sourcegraph/sourcegraph/lib/pointers"
 )
 
 type gitCommitConnectionResolver struct {
@@ -60,13 +61,17 @@ func (r *gitCommitConnectionResolver) afterCursorAsInt() (int, error) {
 
 func (r *gitCommitConnectionResolver) compute(ctx context.Context) ([]*gitdomain.Commit, error) {
 	do := func() ([]*gitdomain.Commit, error) {
-		var n int32
-		// IMPORTANT: We cannot use toValue here because we toValue will return 0 if r.first is nil.
-		// And n will be incorrectly set to 1. A nil value for r.first implies no limits, so skip
-		// setting a value for n completely.
-		if r.first != nil {
-			n = *r.first
-			n++ // fetch +1 additional result so we can determine if a next page exists
+		n := pointers.Deref(r.first, 0)
+
+		// PERF: only request extra if we request more than one result. A
+		// common scenario is requesting the latest commit that modified a
+		// file, but many files have only been modified by the commit that
+		// created them. If we request more than one commit, we have to
+		// traverse the entire git history to find a second commit that doesn't
+		// exist, which is useless information in the case that we only want
+		// the latest commit anyways.
+		if n > 1 {
+			n += 1
 		}
 
 		// If no value for afterCursor is set, then skip is 0. And this is fine as --skip=0 is the
@@ -142,9 +147,14 @@ func (r *gitCommitConnectionResolver) PageInfo(ctx context.Context) (*graphqluti
 
 	limit := int(*r.first)
 
+	// In the special case that only one commit was requested, we want
+	// to always say there is a next page because we didn't request an
+	// extra to know whether there were more.
+	gotSingleRequestedCommit := limit == 1 && totalCommits == limit
+
 	// If a limit is set, we attempt to fetch N+1 commits to know if there is a next page or not. If
 	// we have more than N commits then we have a next page.
-	if totalCommits > limit {
+	if totalCommits > limit || gotSingleRequestedCommit {
 		// Pagination logic below.
 		//
 		// Example:

From 55d78654d570e617a7adafa44bbe719a62a89241 Mon Sep 17 00:00:00 2001
From: Camden Cheek <camden@ccheek.com>
Date: Wed, 1 Nov 2023 16:47:55 -0600
Subject: [PATCH 2/2] add more comments

---
 cmd/frontend/graphqlbackend/git_commits.go | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/cmd/frontend/graphqlbackend/git_commits.go b/cmd/frontend/graphqlbackend/git_commits.go
index 7ee4adb33e3..45db449ce7f 100644
--- a/cmd/frontend/graphqlbackend/git_commits.go
+++ b/cmd/frontend/graphqlbackend/git_commits.go
@@ -70,6 +70,10 @@ func (r *gitCommitConnectionResolver) compute(ctx context.Context) ([]*gitdomain
 		// traverse the entire git history to find a second commit that doesn't
 		// exist, which is useless information in the case that we only want
 		// the latest commit anyways.
+		//
+		// NOTE: in a world where we can view which fields were requested (our
+		// GraphQL library doesn't currently support this), we could make this
+		// conditional on whether `hasNextPage` was part of the request.
 		if n > 1 {
 			n += 1
 		}
@@ -150,6 +154,9 @@ func (r *gitCommitConnectionResolver) PageInfo(ctx context.Context) (*graphqluti
 	// In the special case that only one commit was requested, we want
 	// to always say there is a next page because we didn't request an
 	// extra to know whether there were more.
+	//
+	// NOTE: this means that `hasNextPage` can possibly incorrectly
+	// return true when only one result is requested.
 	gotSingleRequestedCommit := limit == 1 && totalCommits == limit
 
 	// If a limit is set, we attempt to fetch N+1 commits to know if there is a next page or not. If