Fix step to save bundle size on main builds (#42859)

Author: philipp-spiess

enterprise/dev/ci/internal/ci/cache_helpers.go

@@ -13,12 +13,12 @@ func withYarnCache() buildkite.StepOpt {
 	})
 }
 
-func withBundleSizeCache() buildkite.StepOpt {
+func withBundleSizeCache(commit string) buildkite.StepOpt {
 	return buildkite.Cache(&buildkite.CacheOptions{
 		ID:          "bundle_size_cache",
 		Key:         "bundle_size_cache-{{ git.commit }}",
 		RestoreKeys: []string{"bundle_size_cache-{{ git.commit }}"},
-		Paths:       []string{"ui/assets/stats-{{ git.commit }}.json"},
+		Paths:       []string{"ui/assets/stats-" + commit + ".json"},
 		Compress:    true,
 	})
 }

enterprise/dev/ci/internal/ci/operations.go

@@ -222,7 +222,7 @@ func addWebEnterpriseBuild(pipeline *bk.Pipeline, opts CoreTestOperationsOptions
 		cmds = append(cmds,
 			// Emit a stats.json file for bundle size diffs
 			bk.Env("WEBPACK_EXPORT_STATS_FILENAME", "stats-"+commit+".json"),
-			withBundleSizeCache())
+			withBundleSizeCache(commit))
 	}
 
 	if opts.CreateBundleSizeDiff {