Skip to content

Commit b687c6a

Browse files
authored
chore: move to non-deprecated symbol (#140)
move to non-deprecated symbol
1 parent 9859fd4 commit b687c6a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

bindings/go/scip/symbol.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ func (s *symbolParser) parseDescriptor() (*Descriptor, error) {
156156
}
157157
return &Descriptor{Name: name, Disambiguator: disambiguator, Suffix: Descriptor_Method}, s.acceptCharacter('.', "closing method")
158158
case '/':
159-
return &Descriptor{Name: name, Suffix: Descriptor_Package}, nil
159+
return &Descriptor{Name: name, Suffix: Descriptor_Namespace}, nil
160160
case '.':
161161
return &Descriptor{Name: name, Suffix: Descriptor_Term}, nil
162162
case '#':

bindings/go/scip/symbol_formatter.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func (f *SymbolFormatter) FormatSymbol(symbol *Symbol) string {
7171
descriptor := strings.Builder{}
7272
for _, desc := range symbol.Descriptors {
7373
switch desc.Suffix {
74-
case Descriptor_Package:
74+
case Descriptor_Namespace:
7575
descriptor.WriteString(desc.Name)
7676
descriptor.WriteRune('/')
7777
case Descriptor_Type:

bindings/go/scip/symbol_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ func TestParseSymbol(t *testing.T) {
4949
Scheme: "lsif-java",
5050
Package: &Package{Manager: "maven", Name: "package", Version: "1.0.0"},
5151
Descriptors: []*Descriptor{
52-
{Name: "java", Suffix: Descriptor_Package},
53-
{Name: "io", Suffix: Descriptor_Package},
52+
{Name: "java", Suffix: Descriptor_Namespace},
53+
{Name: "io", Suffix: Descriptor_Namespace},
5454
{Name: "File", Suffix: Descriptor_Type},
5555
{Name: "Entry", Suffix: Descriptor_Term},
5656
{Name: "method", Disambiguator: "+1", Suffix: Descriptor_Method},
@@ -65,7 +65,7 @@ func TestParseSymbol(t *testing.T) {
6565
Scheme: "rust-analyzer",
6666
Package: &Package{Manager: "cargo", Name: "std", Version: "1.0.0"},
6767
Descriptors: []*Descriptor{
68-
{Name: "macros", Suffix: Descriptor_Package},
68+
{Name: "macros", Suffix: Descriptor_Namespace},
6969
{Name: "println", Suffix: Descriptor_Macro},
7070
},
7171
},

0 commit comments

Comments
 (0)