feat: Emit refs for constructors (#163)

Author: varungandhi-src

indexer/Indexer.cc

@@ -14,6 +14,7 @@
 #include "clang/AST/DeclCXX.h"
 #include "clang/AST/DeclTemplate.h"
 #include "clang/AST/Expr.h"
+#include "clang/AST/ExprCXX.h"
 #include "clang/AST/RawCommentList.h"
 #include "clang/AST/TypeLoc.h"
 #include "clang/Basic/SourceLocation.h"
@@ -622,6 +623,22 @@ void TuIndexer::saveVarDecl(const clang::VarDecl &varDecl) {
   }
 }
 
+void TuIndexer::saveCXXConstructExpr(
+    const clang::CXXConstructExpr &cxxConstructExpr) {
+  if (auto *cxxConstructorDecl = cxxConstructExpr.getConstructor()) {
+    if (cxxConstructorDecl->isImplicit()) {
+      // SCIP doesn't yet have any way to represent implicitly
+      // synthesized code:
+      // https://github.com/sourcegraph/scip-clang/issues/126
+      return;
+    }
+    if (auto optSymbol =
+            this->symbolFormatter.getFunctionSymbol(*cxxConstructorDecl)) {
+      this->saveReference(*optSymbol, cxxConstructExpr.getBeginLoc());
+    }
+  }
+}
+
 void TuIndexer::saveDeclRefExpr(const clang::DeclRefExpr &declRefExpr) {
   // In the presence of 'using', prefer going to the 'using' instead
   // of directly dereferencing.

indexer/Indexer.h

@@ -22,6 +22,7 @@
 #include "indexer/SymbolFormatter.h"
 
 #define FOR_EACH_EXPR_TO_BE_INDEXED(F) \
+  F(CXXConstruct)                      \
   F(DeclRef)                           \
   F(Member)
 

test/index/functions/ctors_dtors.snapshot.cc

@@ -69,12 +69,14 @@
     D d0;
 //  ^ reference [..] D#
 //    ^^ definition local 6
+//    ^^ reference [..] D#D(ced63f7c635d850d).
     C c1{};
 //  ^ reference [..] C#
 //    ^^ definition local 7
     D d1{};
 //  ^ reference [..] D#
 //    ^^ definition local 8
+//    ^^ reference [..] D#D(ced63f7c635d850d).
     C c2{0, 1};
 //  ^ reference [..] C#
 //    ^^ definition local 9
@@ -89,6 +91,7 @@
     D d3{move(d1)};
 //  ^ reference [..] D#
 //    ^^ definition local 11
+//    ^^ reference [..] D#D(ece7426db7e2c886).
 //            ^^ reference local 8
 
     C c4 = {};
@@ -97,6 +100,7 @@
     D d4 = {};
 //  ^ reference [..] D#
 //    ^^ definition local 13
+//         ^ reference [..] D#D(ced63f7c635d850d).
     C c5 = C();
 //  ^ reference [..] C#
 //    ^^ definition local 14
@@ -105,6 +109,7 @@
 //  ^ reference [..] D#
 //    ^^ definition local 15
 //         ^ reference [..] D#
+//         ^ reference [..] D#D(ced63f7c635d850d).
     C c6 = {0, 1};
 //  ^ reference [..] C#
 //    ^^ definition local 16
@@ -128,5 +133,6 @@
     D d10 = move(d1);
 //  ^ reference [..] D#
 //    ^^^ definition local 21
+//          ^^^^ reference [..] D#D(ece7426db7e2c886).
 //               ^^ reference local 8
   }

test/index/vars/members.snapshot.cc

@@ -29,6 +29,7 @@
     S1(): S0() {
 //  ^^ definition [..] S1#S1(49f6e7a06ebc5aa8).
 //        ^^ reference [..] S0#
+//        ^^ reference [..] S0#S0(49f6e7a06ebc5aa8).
       x = y;
 //    ^ reference [..] S0#x.
 //        ^ reference [..] S0#y.