Skip to content

Commit 6bed78a

Browse files
build: Bump LLVM version to latest
1 parent cc50c52 commit 6bed78a

File tree

3 files changed

+24
-10
lines changed

3 files changed

+24
-10
lines changed

fetch_deps.bzl

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ _BAZEL_SKYLIB_VERSION = "1.3.0"
44
_PLATFORMS_COMMIT = "3fbc687756043fb58a407c2ea8c944bc2fe1d922" # 2022 Nov 10
55
_BAZEL_TOOLCHAIN_VERSION = "0.10.3"
66
_RULES_BOOST_COMMIT = "00b9b9ecb9b43564de44ea0b10e22b29dcf84d79"
7-
_LLVM_COMMIT = "e0f3110b854a476c16cce7b44472cd7838d344e9" # Keep in sync with Version.h
7+
_LLVM_COMMIT = "a344db793aca6881379c7c83f5112d2870dbf958" # Keep in sync with Version.h
88
_ABSL_COMMIT = "4ffaea74c1f5408e0757547a1ca0518ad43fa9f1"
99
_CXXOPTS_VERSION = "3.0.0"
1010
_RAPIDJSON_COMMIT = "a98e99992bd633a2736cc41f96ec85ef0c50e44d"
@@ -79,6 +79,17 @@ def fetch_direct_dependencies():
7979
# Keep the name 'zlib' so that Protobuf doesn't pull in another copy.
8080
#
8181
# https://sourcegraph.com/github.com/protocolbuffers/protobuf/-/blob/protobuf_deps.bzl?L48-58
82+
#
83+
# Yes, LLVM pulls in zlib-ng, but I can't figure out how to unify the two.
84+
# I tried adding this to the llvm_zlib http_archive call:
85+
#
86+
# repo_mapping = {"@zlib": "@llvm_zlib"}
87+
#
88+
# but that resulted in a build error.
89+
# Compiling src/google/protobuf/io/gzip_stream.cc failed: undeclared inclusion(s) in rule '@com_google_protobuf//:protobuf':
90+
# this rule is missing dependency declarations for the following files included by 'src/google/protobuf/io/gzip_stream.cc':
91+
# 'external/zlib/zlib.h'
92+
# 'external/zlib/zconf.h'
8293
http_archive(
8394
name = "zlib",
8495
build_file = "@scip_clang//third_party:zlib.BUILD",
@@ -90,6 +101,16 @@ def fetch_direct_dependencies():
90101
],
91102
)
92103

104+
http_archive(
105+
name = "llvm_zlib",
106+
build_file = "@llvm-raw//utils/bazel/third_party_build:zlib-ng.BUILD",
107+
sha256 = "e36bb346c00472a1f9ff2a0a4643e590a254be6379da7cddd9daeb9a7f296731",
108+
strip_prefix = "zlib-ng-2.0.7",
109+
urls = [
110+
"https://github.com/zlib-ng/zlib-ng/archive/refs/tags/2.0.7.zip",
111+
],
112+
)
113+
93114
http_archive(
94115
name = "llvm_zstd",
95116
build_file = "@llvm-raw//utils/bazel/third_party_build:zstd.BUILD",
@@ -102,7 +123,7 @@ def fetch_direct_dependencies():
102123

103124
http_archive(
104125
name = "llvm-raw",
105-
sha256 = "04b76a5be88331f71a4e4fe96bccfebec302ddd0dbd9418fd5c186a7361c54fb",
126+
sha256 = "9b9c46e9fd3b62cc588bf4a622924b0227624b5741cbc6b909a5d315ec1b79b0",
106127
strip_prefix = "llvm-project-%s" % _LLVM_COMMIT,
107128
build_file_content = "# empty",
108129
urls = ["https://github.com/llvm/llvm-project/archive/%s.tar.gz" % _LLVM_COMMIT],

indexer/Version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ constexpr bool debugMode = false;
1717

1818
#define VERSION "0.3.1"
1919
#define LLVM_COMMIT \
20-
"e0f3110b854a476c16cce7b44472cd7838d344e9" // Keep synced with fetch_deps.bzl
20+
"a344db793aca6881379c7c83f5112d2870dbf958" // Keep synced with fetch_deps.bzl
2121

2222
// TODO: Add scip-clang Git SHA + dirty bit.
2323

setup_deps.bzl

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,14 @@ load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
22
load("@com_github_nelhage_rules_boost//:boost/boost.bzl", "boost_deps")
33
load("@com_grail_bazel_compdb//:deps.bzl", "bazel_compdb_deps")
44
load("@llvm-raw//utils/bazel:configure.bzl", "llvm_configure")
5-
load("@llvm-raw//utils/bazel:terminfo.bzl", "llvm_terminfo_disable")
6-
load("@llvm-raw//utils/bazel:zlib.bzl", "llvm_zlib_external")
75
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
8-
load("@python_3_10//:defs.bzl", "interpreter")
9-
load("@rules_python//python:pip.bzl", "pip_parse")
106
load("@python_deps//:requirements.bzl", install_python_deps = "install_deps")
117

128
def setup_dependencies():
139
bazel_skylib_workspace()
1410
boost_deps()
1511
bazel_compdb_deps()
1612

17-
llvm_terminfo_disable(name = "llvm_terminfo")
18-
llvm_zlib_external(name = "llvm_zlib", external_zlib = "@zlib//:zlib")
19-
2013
# FIXME: Should we allow all targets in a release build?
2114
# Limit the number of backends here to save on compile time for now.
2215
llvm_configure(name = "llvm-project", targets = ["AArch64", "X86"])

0 commit comments

Comments
 (0)