Skip to content

Commit 731d173

Browse files
committed
update default ssm parameter to have empty value for route_53_zone_id
1 parent ad65050 commit 731d173

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.3.0
1+
1.3.1

example/data.tf

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ data "aws_vpc" "vpc" {
1010
}
1111
}
1212

13+
data "aws_route53_zone" "this" {
14+
name = local.route_53_zone
15+
}
16+
1317
## public
1418
data "aws_subnets" "public" {
1519
filter {
@@ -18,8 +22,8 @@ data "aws_subnets" "public" {
1822
## if `var.public_subnet_names` is unassigned, it will attempt to lookup the
1923
## subnets created by github.com/sourcefuse/terraform-aws-ref-arch-network
2024
values = length(var.public_subnet_names) > 0 ? var.public_subnet_names : [
21-
"${var.namespace}-${var.environment}-public-${var.region}a",
22-
"${var.namespace}-${var.environment}-public-${var.region}b"
25+
"${var.namespace}-${var.environment}-public-subnet-public-${var.region}a",
26+
"${var.namespace}-${var.environment}-public-subnet-public-${var.region}b"
2327
]
2428
}
2529
}
@@ -32,8 +36,8 @@ data "aws_subnets" "private" {
3236
## if `var.private_subnet_names` is unassigned, it will attempt to lookup the
3337
## subnets created by github.com/sourcefuse/terraform-aws-ref-arch-network
3438
values = length(var.private_subnet_names) > 0 ? var.private_subnet_names : [
35-
"${var.namespace}-${var.environment}-private-${var.region}a",
36-
"${var.namespace}-${var.environment}-private-${var.region}b"
39+
"${var.namespace}-${var.environment}-private-subnet-private-${var.region}a",
40+
"${var.namespace}-${var.environment}-private-subnet-private-${var.region}b"
3741
]
3842
}
3943
}

example/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ module "ecs" {
4949

5050
## create acm certificate and dns record for health check
5151
route_53_zone_name = local.route_53_zone
52+
route_53_zone_id = data.aws_route53_zone.this.id
5253
acm_domain_name = "healthcheck-ecs-${var.namespace}-${var.environment}.${local.route_53_zone}"
5354
acm_subject_alternative_names = []
5455
health_check_route_53_records = [

modules/health-check/outputs.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ output "security_group_id" {
2626
## route 53
2727
output "route_53_fqdn" {
2828
description = "Health check FQDN record created in Route 53."
29-
value = [for x in aws_route53_record.this : x.fqdn]
29+
value = try([for x in aws_route53_record.this : x.fqdn], [])
3030
}

0 commit comments

Comments
 (0)