Merge pull request #23 from sourcefuse/chore/additional-cleanup

chore/additional-cleanup

Author: James Crowley

.version

@@ -1 +1 @@
-1.2.4
+1.2.5

README.md

@@ -86,9 +86,7 @@ module "ecs" {
 | Name | Type |
 |------|------|
 | [aws_cloudwatch_log_group.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_group) | resource |
-| [aws_iam_policy.secrets_manager_read_policy](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy) | resource |
 | [aws_iam_policy_attachment.execution](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
-| [aws_iam_policy_attachment.secrets_manager_read](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy_attachment) | resource |
 | [aws_iam_role.execution](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role) | resource |
 | [aws_lb_listener.http](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb_listener) | resource |
 | [aws_lb_listener.https](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb_listener) | resource |

iam.tf

@@ -28,33 +28,3 @@ resource "aws_iam_policy_attachment" "execution" {
   policy_arn = each.value
   roles      = [aws_iam_role.execution.name]
 }
-
-################################################################################
-## secrets manager
-################################################################################
-resource "aws_iam_policy" "secrets_manager_read_policy" {
-  name_prefix = "${local.cluster_name}-secrets-manager-ro-"
-
-  policy = jsonencode({
-    Version = "2012-10-17",
-    Statement = [
-      {
-        Effect   = "Allow",
-        Resource = "*"
-        Action = [
-          "secretsmanager:GetSecretValue"
-        ],
-      }
-    ]
-  })
-
-  tags = merge(var.tags, tomap({
-    NamePrefix = "${local.cluster_name}-secrets-manager-ro-"
-  }))
-}
-
-resource "aws_iam_policy_attachment" "secrets_manager_read" {
-  name       = "${local.cluster_name}-secrets-manager-ro"
-  roles      = [aws_iam_role.execution.name]
-  policy_arn = aws_iam_policy.secrets_manager_read_policy.arn
-}

locals.tf

@@ -17,8 +17,34 @@ locals {
       description = "ALB ARN"
       type        = "String"
     },
+    {
+      name        = "/${var.namespace}/${var.environment}/alb/${module.alb.alb_name}/dns_zone_id"
+      value       = module.alb.alb_zone_id
+      description = "ALB Zone ID"
+      type        = "String"
+    },
+    {
+      name        = "/${var.namespace}/${var.environment}/alb/${module.alb.alb_name}/health_check_fqdn"
+      value       = module.health_check.route_53_fqdn
+      description = "ALB Health Check FQDN."
+      type        = "String"
+    },
+
+    ## acm
+    {
+      name        = "/${var.namespace}/${var.environment}/alb/${module.alb.alb_name}/certificate_arn"
+      value       = try(module.acm.arn, "Not Assigned")
+      description = "ACM Certificate ARN."
+      type        = "String"
+    },
 
     ## ecs
+    {
+      name        = "/${var.namespace}/${var.environment}/ecs/${module.ecs.cluster_name}/cluster_name"
+      value       = module.ecs.cluster_name
+      description = "ECS Cluster Name"
+      type        = "String"
+    },
     {
       name        = "/${var.namespace}/${var.environment}/ecs/${module.ecs.cluster_name}/id"
       value       = module.ecs.cluster_id