Skip to content

Commit 3c5ef05

Browse files
committed
fix(arc-docs): review changes in pr
review changes GH-26
1 parent 37e00f2 commit 3c5ef05

File tree

11 files changed

+326
-122
lines changed

11 files changed

+326
-122
lines changed

angular.json

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@
5656
"budgets": [
5757
{
5858
"type": "initial",
59-
"maximumWarning": "5mb",
60-
"maximumError": "5mb"
59+
"maximumWarning": "10mb",
60+
"maximumError": "10mb"
6161
},
6262
{
6363
"type": "anyComponentStyle",
@@ -92,8 +92,8 @@
9292
},
9393
{
9494
"type": "anyComponentStyle",
95-
"maximumWarning": "5mb",
96-
"maximumError": "5mb"
95+
"maximumWarning": "10mb",
96+
"maximumError": "10mb"
9797
}
9898
]
9999
}
@@ -194,6 +194,7 @@
194194
"polyfills": ["zone.js"],
195195
"tsConfig": "projects/arc-docs/tsconfig.app.json",
196196
"inlineStyleLanguage": "scss",
197+
"optimization": false,
197198
"assets": [
198199
"projects/arc-docs/src/favicon.ico",
199200
{ "glob": "**/*", "input": "node_modules/monaco-editor", "output": "/assets/monaco/" },
@@ -203,22 +204,29 @@
203204
"output": "/assets/"
204205
}
205206
],
207+
208+
206209
"styles": [
207210
"./node_modules/@angular/material/prebuilt-themes/indigo-pink.css",
208211
"node_modules/eva-icons/style/scss/eva-icons.scss",
209212
"node_modules/@nebular/theme/styles/prebuilt/dark.css",
210213
"projects/arc-docs/src/styles.scss"
211214
],
212215
"scripts": [],
213-
"allowedCommonJsDependencies": ["lodash", "eva-icons", "CommonJS"]
216+
"allowedCommonJsDependencies": ["lodash", "eva-icons", "CommonJS"],
217+
"stylePreprocessorOptions": {
218+
"includePaths": [
219+
"projects/arc-lib/src/lib/theme/styles"
220+
]
221+
}
214222
},
215223
"configurations": {
216224
"production": {
217225
"budgets": [
218226
{
219227
"type": "initial",
220-
"maximumWarning": "5mb",
221-
"maximumError": "4mb"
228+
"maximumWarning": "10mb",
229+
"maximumError": "10mb"
222230
},
223231
{
224232
"type": "anyComponentStyle",
@@ -316,13 +324,13 @@
316324
"budgets": [
317325
{
318326
"type": "initial",
319-
"maximumWarning": "5mb",
320-
"maximumError": "5mb"
327+
"maximumWarning": "10mb",
328+
"maximumError": "10mb"
321329
},
322330
{
323331
"type": "anyComponentStyle",
324-
"maximumWarning": "5mb",
325-
"maximumError": "5mb"
332+
"maximumWarning": "10mb",
333+
"maximumError": "10mb"
326334
}
327335
],
328336
"outputHashing": "all"
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
export const DOCUMENTATION_MENU_ITEMS = [
2+
{
3+
title: 'Getting Started',
4+
icon: 'book-outline',
5+
children: [
6+
{
7+
title: 'Introduction',
8+
link: '/docs/getting-started',
9+
},
10+
],
11+
},
12+
{
13+
title: 'Guide',
14+
icon: 'book-outline',
15+
children: [
16+
{
17+
title: 'Cloning Boilerplate',
18+
link: '/docs/guide/clone',
19+
},
20+
{
21+
title: 'Backend Integration',
22+
},
23+
],
24+
},
25+
];

projects/arc-docs/src/app/docs/docs.component.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Ensure the comments are properly placed if you're using them for debugging or development
12
@use 'sass:map';
23
@use '../../../../arc-lib/src/lib/theme/styles/variables' as *;
34
@use '@nebular/theme/styles/theming' as *;
@@ -63,9 +64,8 @@
6364
}
6465
}
6566
}
66-
.hi {
67-
text-align: center;
68-
}
67+
68+
6969
.header-wrapper {
7070
width: 100%;
7171
}

projects/arc-docs/src/app/docs/docs.component.ts

Lines changed: 3 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -6,62 +6,23 @@ import {RouteComponentBaseDirective} from '@project-lib/core/route-component-bas
66
import {IconPacksManagerService} from '@project-lib/theme/services';
77
import {takeUntil} from 'rxjs';
88
import {Location} from '@angular/common';
9+
import {DOCUMENTATION_MENU_ITEMS} from '../constants/docs-menu.contant';
910

1011
@Component({
1112
selector: 'app-docs',
1213
templateUrl: './docs.component.html',
1314
styleUrls: ['./docs.component.scss'],
1415
})
15-
export class DocsComponent
16-
extends RouteComponentBaseDirective
17-
implements OnInit
18-
{
16+
export class DocsComponent extends RouteComponentBaseDirective {
1917
constructor(
2018
override readonly route: ActivatedRoute,
2119
override readonly location: Location,
22-
private readonly sidebarService: NbSidebarService,
23-
private readonly authService: AuthService,
24-
private readonly menuService: NbMenuService,
2520
private readonly iconMgr: IconPacksManagerService,
2621
private router: Router,
2722
) {
2823
super(route, location);
2924
this.iconMgr.registerSvgs();
3025
}
3126

32-
menu: NbMenuItem[] = [
33-
{
34-
title: 'Getting Started',
35-
icon: 'book-outline',
36-
// pathMatch: 'prefix',
37-
children: [
38-
{
39-
title: 'Introduction',
40-
link: '/docs/getting-started',
41-
},
42-
],
43-
},
44-
{
45-
title: 'Guide',
46-
icon: 'book-outline',
47-
children: [
48-
{
49-
title: 'Cloning Boilerplate',
50-
link: '/docs/guide/clone',
51-
},
52-
{
53-
title: 'Backend Integration',
54-
},
55-
],
56-
},
57-
];
58-
59-
ngOnInit(): void {
60-
this.menuService
61-
.onItemClick()
62-
.pipe(takeUntil(this._destroy$))
63-
.subscribe(menu => {
64-
console.log(menu);
65-
});
66-
}
27+
menu: NbMenuItem[] = DOCUMENTATION_MENU_ITEMS;
6728
}

projects/arc-docs/src/app/docs/docs.module.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,8 @@ import {APP_CONFIG} from '@project-lib/app-config';
1515
@NgModule({
1616
declarations: [DocsComponent],
1717
imports: [
18-
CommonModule,
19-
2018
DocsRoutingModule,
2119
ThemeModule,
22-
HttpClientModule,
2320
HeaderComponent,
2421
SidebarComponent,
2522
CoreAuthModule,

projects/arc-docs/src/styles.scss

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
/* You can add global styles to this file, and also import other style files */
2-
@use '../../arc/src/themes.scss' as *;
3-
@use 'sass:map';
4-
@use '../../arc-lib/src/lib/theme/styles/index' as *;
52
@use '@nebular/theme/styles/globals' as *;
63
@use '@nebular/auth/styles/globals' as *;
7-
@use '../../arc-lib/src/lib/theme/styles/variables' as *;
4+
@import 'index';
5+
@import 'themes';
86

97
@include nb-install() {
108
@include nb-theme-global();

0 commit comments

Comments
 (0)