Skip to content

Commit 16e86b0

Browse files
committed
fix(arc-saas): review changes
review changes GH-34
1 parent 6179249 commit 16e86b0

File tree

9 files changed

+3
-33
lines changed

9 files changed

+3
-33
lines changed

projects/saas-ui/src/app/main/components/billing-plan/billing-plan.component.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ <h2>Billing Details</h2>
88
class="ag-theme-quartz"
99
[rowData]="rowData"
1010
[columnDefs]="colDefs"
11-
[pagination]="pagination"
12-
[paginationPageSize]="paginationPageSize"
13-
[paginationPageSizeSelector]="paginationPageSizeSelector"
1411
>
1512
</ag-grid-angular>
1613
</nb-card-body>

projects/saas-ui/src/app/main/components/billing-plan/billing-plan.component.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ export class BillingPlanComponent
2929
rowData: AnyObject = [];
3030
data: AnyObject = [];
3131
tenants: AnyObject[];
32-
// for Pagination
33-
pagination = true;
34-
paginationPageSize = 5;
35-
paginationPageSizeSelector = [5, 10, 20, 50, 100];
3632

3733
constructor(
3834
protected override readonly location: Location,

projects/saas-ui/src/app/main/components/lead-list/lead-list.component.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ <h2>Lead Listing</h2>
88
class="ag-theme-quartz"
99
[rowData]="rowData"
1010
[columnDefs]="colDefs"
11-
[pagination]="pagination"
12-
[paginationPageSize]="paginationPageSize"
13-
[paginationPageSizeSelector]="paginationPageSizeSelector"
1411
>
1512
</ag-grid-angular>
1613
</nb-card-body>

projects/saas-ui/src/app/main/components/lead-list/lead-list.component.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@ export class LeadListComponent
3131
filter: BackendFilter<Lead> = {
3232
include: [{relation: 'address'}],
3333
};
34-
// for Pagination
35-
pagination = true;
36-
paginationPageSize = 5;
37-
paginationPageSizeSelector = [5, 10, 20, 50, 100];
34+
3835
constructor(
3936
protected override readonly location: Location,
4037
protected override readonly route: ActivatedRoute,

projects/saas-ui/src/app/main/components/manage-plans/manage-plans.component.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ <h2>Manage Plan</h2>
1212
[rowSelection]="rowSelection"
1313
(gridReady)="onGridReady($event)"
1414
(rowEditingStopped)="(onRowEditingStopped)"
15-
[pagination]="pagination"
16-
[paginationPageSize]="paginationPageSize"
17-
[paginationPageSizeSelector]="paginationPageSizeSelector"
1815
>
1916
</ag-grid-angular>
2017
<!-- Add Plan Button-->

projects/saas-ui/src/app/main/components/manage-plans/manage-plans.component.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,6 @@ export class ManagePlansComponent
3939
rowData = [];
4040
public rowSelection: 'single' | 'multiple' = 'single';
4141
tenants: AnyObject[];
42-
// for Pagination
43-
pagination = true;
44-
paginationPageSize = 5;
45-
paginationPageSizeSelector = [5, 10, 20, 50, 100];
4642
filter: BackendFilter<AnyObject> = {
4743
include: [{relation: 'currency'}, {relation: 'billingCycle'}],
4844
};

projects/saas-ui/src/app/main/components/onboarding-tenant-list/onboarding-tenant-list.component.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ <h2>OnBoarded Tenant List</h2>
88
class="ag-theme-quartz"
99
[rowData]="rowData"
1010
[columnDefs]="colDefs"
11-
[pagination]="pagination"
12-
[paginationPageSize]="paginationPageSize"
13-
[paginationPageSizeSelector]="paginationPageSizeSelector"
1411
>
1512
</ag-grid-angular>
1613
</nb-card-body>

projects/saas-ui/src/app/main/components/onboarding-tenant-list/onboarding-tenant-list.component.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ export class OnboardingTenantListComponent
2828
rowData = [];
2929
tenants: any;
3030
leads: any;
31-
// for Pagination
32-
pagination = true;
33-
paginationPageSize = 5;
34-
paginationPageSizeSelector = [5, 10, 20, 50, 100];
3531
filter: BackendFilter<Tenant> = {
3632
include: [{relation: 'address'}],
3733
};

projects/saas-ui/src/app/on-boarding/on-boarding-service.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,16 @@ import {
99
Where,
1010
} from '@project-lib/core/api';
1111
import {AuthTokenSkipHeader} from '@project-lib/core/constants';
12-
import {Observable, Subject, filter, map, of} from 'rxjs';
12+
import {Observable} from 'rxjs';
1313
import {
1414
VerifyEmailCommand,
1515
GetLeadByIdCommand,
1616
AddTenantFromLeadCommand,
17-
GetPlanCommand,
1817
AddLeadCommand,
1918
GetLeadListCommand,
2019
} from './commands';
2120
import {GetPlanAdapter} from './adapters';
22-
import {Lead, Tenant, Plan} from './models';
23-
24-
import {GetBillingDetails} from '../main/commands/get-billing.command';
21+
import {Lead, Tenant} from './models';
2522
import {APP_CONFIG} from '@project-lib/app-config';
2623
import {IAnyObject} from '@project-lib/core/i-any-object';
2724
interface BackendFilter<MT extends object = AnyObject> {

0 commit comments

Comments
 (0)