Skip to content

Commit 6eb0cc9

Browse files
committed
Revert "Disable treeview caching"
This reverts commit 53d6c3d.
1 parent 53d6c3d commit 6eb0cc9

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

src/commands/showPanel.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { Editor } from "../utils/editor";
1414
import { FRONTEND_ELEMENT_ID } from "../constants";
1515
import { client, SOURCE_ACADEMY_ICON_URI } from "../extension";
1616
import _ from "lodash";
17-
import { enableAssessmentsTreeData } from "../treeview";
17+
import { treeDataProvider } from "../treeview";
1818

1919
let panel: vscode.WebviewPanel | null = null;
2020
// This needs to be a reference to active
@@ -98,7 +98,7 @@ async function handleMessage(
9898
const { assessmentOverviews, courseId } = message;
9999
context.globalState.update("assessmentOverviews", assessmentOverviews);
100100
context.globalState.update("courseId", courseId);
101-
enableAssessmentsTreeData();
101+
treeDataProvider.refresh();
102102
break;
103103
}
104104
console.log(`${Date.now()} Finish handleMessage: ${message.type}`);

src/treeview/index.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@ import { VscAssessmentOverview } from "../utils/messages";
33
import { SOURCE_ACADEMY_ICON_URI } from "../extension";
44

55
export let treeDataProvider: AssessmentsSidebarProvider;
6-
export function enableAssessmentsTreeData() {
7-
treeDataProvider?.enableData();
8-
}
96

107
// This will be a source of bug on first extension loads!!
118
let courseId: number;
@@ -22,12 +19,7 @@ export function setupTreeView(context: vscode.ExtensionContext) {
2219
export class AssessmentsSidebarProvider
2320
implements vscode.TreeDataProvider<BaseTreeItem>
2421
{
25-
constructor(private context: vscode.ExtensionContext, private dataEnabled: boolean = false) {}
26-
27-
enableData() {
28-
this.dataEnabled = true;
29-
this.refresh();
30-
}
22+
constructor(private context: vscode.ExtensionContext) {}
3123

3224
private _onDidChangeTreeData: vscode.EventEmitter<
3325
BaseTreeItem | undefined | null | void
@@ -41,9 +33,6 @@ export class AssessmentsSidebarProvider
4133
}
4234

4335
getChildren(element?: BaseTreeItem): Thenable<BaseTreeItem[]> {
44-
if (!this.dataEnabled) {
45-
return Promise.resolve([]);
46-
}
4736
// @ts-ignore
4837
const assessmentOverviews: VscAssessmentOverview[] =
4938
this.context.globalState.get("assessmentOverviews");

0 commit comments

Comments
 (0)