added case where user clicks save all even when there is multiple top level files or folders

Author: linedoestrolling

src/commons/sagas/GitHubPersistenceSaga.ts

@@ -30,10 +30,11 @@ import FileExplorerDialog, { FileExplorerDialogProps } from '../gitHubOverlay/Fi
 import RepositoryDialog, { RepositoryDialogProps } from '../gitHubOverlay/RepositoryDialog';
 import { actions } from '../utils/ActionsHelper';
 import Constants from '../utils/Constants';
-import { promisifyDialog } from '../utils/DialogHelper';
+import { promisifyDialog, showSimpleErrorDialog } from '../utils/DialogHelper';
 import { dismiss, showMessage, showSuccessMessage, showWarningMessage } from '../utils/notifications/NotificationsHelper';
 import { EditorTabState } from '../workspace/WorkspaceTypes';
 import { Intent } from '@blueprintjs/core';
+import { filePathRegex } from '../utils/PersistenceHelper';
 
 export function* GitHubPersistenceSaga(): SagaIterator {
   yield takeLatest(LOGIN_GITHUB, githubLoginSaga);
@@ -288,6 +289,39 @@ function* githubSaveAll(): any {
     >;
 
     if (store.getState().fileSystem.persistenceFileArray.length === 0) {
+      // check if there is only one top level folder 
+      const fileSystem: FSModule | null = yield select(
+        (state: OverallState) => state.fileSystem.inBrowserFileSystem
+      );
+
+      // If the file system is not initialised, do nothing.
+      if (fileSystem === null) {
+        yield call(console.log, 'no filesystem!'); // TODO change to throw new Error
+        return;
+      }
+      const currFiles: Record<string, string> = yield call(
+        retrieveFilesInWorkspaceAsRecord,
+        'playground',
+        fileSystem
+      );
+      const testPaths: Set<string> = new Set();
+        Object.keys(currFiles).forEach(e => {
+          const regexResult = filePathRegex.exec(e)!;
+          testPaths.add(regexResult![1].slice('/playground/'.length, -1).split('/')[0]); //TODO hardcoded playground
+        });
+      if (testPaths.size !== 1) {
+        yield call(showSimpleErrorDialog, {
+          title: 'Unable to Save All',
+          contents: (
+            "There must be exactly one top level folder present in order to use Save All."
+          ),
+          label: 'OK'
+        });
+        return;
+      }
+
+      //only one top level folder, proceeding to selection
+
       type ListForAuthenticatedUserData = GetResponseDataTypeFromEndpointMethod<
         typeof octokit.repos.listForAuthenticatedUser
       >;

src/features/github/GitHubUtils.tsx

@@ -207,11 +207,9 @@ export async function checkIsFile(
   const files = results.data;
 
   if (Array.isArray(files)) {
-    console.log('folder detected');
     return false;
   }
 
-  console.log('file detected');
   return true;
 }
 
@@ -256,9 +254,7 @@ export async function openFileInEditor(
 
   store.dispatch(actions.deleteAllGithubSaveInfo());
   const fileSystem: FSModule | null = store.getState().fileSystem.inBrowserFileSystem;
-  if (fileSystem === null) {
-    console.log('no filesystem!');
-  } else {
+  if (fileSystem !== null) {
     await rmFilesInDirRecursively(fileSystem, '/playground');
   }
   type GetContentResponse = GetResponseTypeFromEndpointMethod<typeof octokit.repos.getContent>;
@@ -271,7 +267,6 @@ export async function openFileInEditor(
 
   const regexResult = filePathRegex.exec(filePath);
   if (regexResult === null) {
-    console.log('Regex null');
     return;
   }
   const newFilePath = regexResult[2] + regexResult[3];