Skip to content

Commit 0a41698

Browse files
committed
Refactor leaderboard components to use slice for top entries instead of filter
1 parent b78304a commit 0a41698

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/pages/leaderboard/subcomponents/ContestLeaderboard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ const ContestLeaderboard: React.FC<Props> = ({ type, contestID }) => {
6565

6666
// Display constants
6767
const visibleEntries = useTypedSelector(store => store.session.topContestLeaderboardDisplay);
68-
const top3 = rankedLeaderboard.filter(x => x.rank !== undefined && x.rank <= 3);
69-
const rest = rankedLeaderboard.filter(x => x.rank !== undefined && x.rank <= Number(visibleEntries) && x.rank > 3);
68+
const top3 = rankedLeaderboard.slice(0, 3);
69+
const rest = rankedLeaderboard.slice(3, Number(visibleEntries));
7070

7171
// const workspaceLocation = 'assessment';
7272
const navigate = useNavigate();

src/pages/leaderboard/subcomponents/OverallLeaderboard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const OverallLeaderboard: React.FC = () => {
4747

4848
// Display constants
4949
const visibleEntries = useTypedSelector(store => store.session.topLeaderboardDisplay);
50-
const topX = rankedLeaderboard.filter(x => x.rank <= Number(visibleEntries));
50+
const topX = rankedLeaderboard.slice(0, Number(visibleEntries));
5151

5252
// Define column definitions for ag-Grid
5353
const columnDefs: ColDef<LeaderboardRow>[] = useMemo(

0 commit comments

Comments
 (0)