Sample cutoff decay level docs/validations incorrect?

[ethancrawford]

I noticed that the docstring for the sample cutoff decay level parameter doesn't match the validations it has. (See https://github.com/samaaron/sonic-pi/blob/master/app/server/sonicpi/lib/sonicpi/synths/synthinfo.rb#L2852-L2853)

For the tb303 synth, the cutoff decay level is between 0 and 1, and the validations there appear to match. (See https://github.com/samaaron/sonic-pi/blob/master/app/server/sonicpi/lib/sonicpi/synths/synthinfo.rb#L1501-L1502)

Also, I wasn't sure whether you wanted both the tb303 and sample cutoff decay values to refer to a MIDI value, or one to be 0 - 1 and the other 0 - 130 still... otherwise I would change this myself.

[ethancrawford]

It seems that the 0 - 1 vs 0 - 130 thing applies to cutoff attack level and cutoff sustain level for the sample player also.

[samaaron]

I did try changing the :tb303 synth to match but it totally changed the sound which was unfortunate. Perhaps I'll have another go at changing to match yet preserving timbre.