Suggested addition to the sound.rb file to find sample names

[rbnpi]

I have found the need to know the sample name matched by path,n and would find it useful to have a function like this added. Just returns first single match.

define :findSampleName do |path,num|
  #returns matched sample name if any for given path and offset
  filts_and_sources,_ = sample_split_filts_and_opts [path,num]
  if sample_find_candidates(filts_and_sources).length > 0
    return sample_find_candidates(filts_and_sources)[0]
  else return "none found"
  end
end

could return nil instead for no match.
It seems to work ok when run in a SP buffer.
EDIT (of course changed to Ruby def format to go in sound.rb file)

[ethancrawford]

@samaaron what are your thoughts about extending the sample_names/all_sample_names fns so that they can also accept sources and filters etc to give the names of external samples, as well as keeping the current behaviour when printing built-in sample names?

[samaaron]

Sounds very reasonable :-)

[ethancrawford]

Following on from my above idea @samaaron - it seems that there may be situations (possibly not that common, but there nonetheless) where if you desire to puts the list of external sample names, the list is so big that it's too large to send via OSC to the Sonic Pi log panel. What would be the correct way to handle this? truncate the list and print a further log message warning that some were left off because of this? (See #2347 for a related issue)

[samaaron]

I think truncating it makes a lot of sense. Perhaps with a message of how many chars were truncated.