Synths - fix up sc808 cymbal

Author: samaaron

app/server/ruby/lib/sonicpi/synths/synthinfo.rb

@@ -4693,38 +4693,27 @@ def synth_name
         "sc808_cymbal"
       end
 
-      def on_start(studio, args_h)
-        args_h[:rand_buf] = studio.rand_buf_id
-      end
-
       def doc
         "Cymbal of the SC808 drum machine based on [Yoshinosuke Horiuchi's](https://www.patreon.com/4H/posts) implementation of the legendary rhythm composer from the early 80s. This is a percussive synth, so it does not use the standard envelope parameters, neither does it feature slideable parameters."
       end
 
       def arg_defaults
         {
           :amp => 1,
+          :amp_slide => 0,
+          :amp_slide_shape => 1,
+          :amp_slide_curve => 0,
           :pan => 0,
-          :decay => 0.5,
+          :pan_slide => 0,
+          :pan_slide_shape => 1,
+          :pan_slide_curve => 0,
+          :decay => 2,
+          :decay_curve => -3,
+          :tone => 0.002
         }
       end
 
-      def default_arg_info
-        super.merge({
-          :amp =>
-          {
-            :doc => "The amplitude of the sound. Typically a value between 0 and 1. Higher amplitudes may be used, but won't make the sound louder, they will just reduce the quality of all the sounds currently being played (due to compression.)",
-            :validations => [v_positive(:amp)],
-            :modulatable => false
-          },
-          :pan =>
-          {
-            :doc => "Position of sound in stereo. With headphones on, this means how much of the sound is in the left ear, and how much is in the right ear. With a value of -1, the sound is completely in the left ear, a value of 0 puts the sound equally in both ears and a value of 1 puts the sound in the right ear. Values in between -1 and 1 move the sound accordingly.",
-            :validations => [v_between_inclusive(:pan, -1, 1)],
-            :modulatable => false
-          },
-        })
-      end
+
 
       def specific_arg_info
         {
@@ -4734,6 +4723,18 @@ def specific_arg_info
             :validations => [v_positive(:decay)],
             :modulatable => false
           },
+          :decay_curve =>
+          {
+            :doc => "Curve value for the decay of the hi-hat",
+            :validations => [],
+            :modulatable => false
+          },
+          :tone =>
+          {
+            :doc => "Change the timbre by adding in additional frequencies to the sound",
+            :validations => [v_positive(:tone), v_less_than_oet(:tone, 1)],
+            :modulatable => true
+          },
         }
       end
     end

etc/synthdefs/compiled/sonic-pi-sc808_cymbal.scsyndef

@@ -557,17 +557,24 @@ SynthDef('sonic-pi-sc808_open_hihat', {|
 }).writeDefFile("/Users/sam/Development/sonic-pi/etc/synthdefs/compiled/");
 )
 
+(
 SynthDef('sonic-pi-sc808_cymbal', {|
 
-  amp = 1,
-  pan = 0,
+  amp = 1, amp_slide = 0, amp_slide_shape = 1, amp_slide_curve = 0,
+  pan = 0, pan_slide = 0, pan_slide_shape = 1, pan_slide_curve = 0,
+
   decay=2,
-  tone=0.002,
+  decay_curve = -3
+  tone=0.25,
 
   out_bus = 0|
 
   var sig, sig1, sig2, sig2a, sig2b, sig3, env1, env2, env2b, env3, osc1, osc2, osc3, osc4, osc5, osc6, sum;
-  env1 = EnvGen.kr(Env.perc(0.3, decay, curve:-3), doneAction:2);
+
+  amp = amp.varlag(amp_slide, amp_slide_curve, amp_slide_shape);
+  pan = pan.varlag(pan_slide, pan_slide_curve, pan_slide_shape);
+  tone = tone * 0.008;
+  env1 = EnvGen.kr(Env.perc(0.3, decay, curve:decay_curve), doneAction:2);
   env2 = EnvGen.kr(Env.new([0, 0.6, 0], [0.1, decay*0.7], -5), doneAction:0);
   env2b = EnvGen.kr(Env.new([0, 0.3, 0], [0.1, decay*20], -120), doneAction:0);
   env3 = EnvGen.kr(Env.new([0, 1, 0], [0, decay*5], curve:-150), doneAction:0);
@@ -599,9 +606,9 @@ SynthDef('sonic-pi-sc808_cymbal', {|
   sig3 = sig3 * env3;
   sum = sig1 + sig2a + sig2b + sig3;
   sum = LPF.ar(sum, 4000);
-  sum = Pan2.ar(sum, 0);
   sum = sum * amp * 12;
-  Out.ar(0, sum);
+  DetectSilence.ar(sum, doneAction: Done.freeSelf);
+  Out.ar(0, Pan2.ar(sum, pan));
 
-}).writeDefFile("/Users/sam/Development/RPi/sonic-pi/etc/synthdefs/compiled/");
+}).writeDefFile("/Users/sam/Development/sonic-pi/etc/synthdefs/compiled/");
 )