Skip to content

Commit d4445d8

Browse files
authored
Merge pull request #2731 from emlyn/fixbell
Ensure bell synths get freed when used with amp: 0
2 parents 13f3127 + d517441 commit d4445d8

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ especially the following individuals who have been remarkably generous:
107107
* [Paul Williams](https://pcwilliams.design)
108108
* [Pit Noack](http://www.maschinennah.de/)
109109
* [Richard Buckley](https://burgundycomputing.com)
110+
* [Richard Bullington-McGuire](https://www.obscure.org/~rbulling/)
110111
* [Robin Newman](https://twitter.com/rbnman)
111112
* [Sam Halliday](https://github.com/fommil)
112113
* [Sean Raser](https://twitter.com/sraser88)
Binary file not shown.
Binary file not shown.

etc/synthdefs/designs/overtone/sonic-pi/src/sonic_pi/bell.clj

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,9 @@
105105
amp (varlag amp amp_slide amp_slide_curve amp_slide_shape)
106106
pan (varlag pan pan_slide pan_slide_curve pan_slide_shape)
107107
freq (midicps note)
108-
snd (* amp (bell-partials freq attack decay sustain release attack_level decay_level sustain_level dull-partials))]
109-
(detect-silence snd :action FREE)
108+
snd (* amp (bell-partials freq attack decay sustain release attack_level decay_level sustain_level dull-partials))
109+
det (+ snd (impulse:ar 0))]
110+
(detect-silence det :action FREE)
110111
(out out_bus (pan2 snd pan))))
111112

112113
(defsynth sonic-pi-pretty_bell [note 52
@@ -135,8 +136,9 @@
135136
amp (varlag amp amp_slide amp_slide_curve amp_slide_shape)
136137
pan (varlag pan pan_slide pan_slide_curve pan_slide_shape)
137138
freq (midicps note)
138-
snd (* amp (bell-partials freq attack decay sustain release attack_level decay_level sustain_level partials))]
139-
(detect-silence snd :action FREE)
139+
snd (* amp (bell-partials freq attack decay sustain release attack_level decay_level sustain_level partials))
140+
det (+ snd (impulse:ar 0))]
141+
(detect-silence det :action FREE)
140142
(out out_bus (pan2 snd pan)))))
141143

142144
(comment

0 commit comments

Comments
 (0)