Synths - fix up sc808 rimshot

Author: samaaron

app/server/ruby/lib/sonicpi/synths/synthinfo.rb

@@ -4292,70 +4292,76 @@ def synth_name
         "sc808_rimshot"
       end
 
-      def on_start(studio, args_h)
-        args_h[:rand_buf] = studio.rand_buf_id
-      end
-
       def doc
         "Rimshot of the SC808 drum machine based on [Yoshinosuke Horiuchi's](https://www.patreon.com/4H/posts) implementation of the legendary rhythm composer from the early 80s. This is a percussive synth, so it does not use the standard envelope parameters, neither does it feature slideable parameters."
       end
 
       def arg_defaults
         {
           :note => 92,
+          :detune => -22,
           :amp => 1,
+          :amp_slide => 0,
+          :amp_slide_shape => 1,
+          :amp_slide_curve => 0,
           :pan => 0,
-          :note2 => 70,
-          :cutoff_lo => 63,
-          :cutoff_hi => 118,
+          :pan_slide => 0,
+          :pan_slide_shape => 1,
+          :pan_slide_curve => 0,
+          :lpf => 63,
+          :lpf_slide => 0,
+          :lpf_slide_shape => 1,
+          :lpf_slide_curve => 0,
+          :hpf => 118,
+          :hpf_slide => 0,
+          :hpf_slide_shape => 1,
+          :hpf_slide_curve => 0,
+          :decay =>  0.07,
+          :decay_curve => -42,
+          :click => 1
         }
       end
 
-      def default_arg_info
-        super.merge({
-          :note =>
-          {
-            :doc => "Note to play. Either a MIDI number or a symbol representing a note. For example: `30`, `52`, `:C`, `:C2`, `:Eb4`, or `:Ds3`",
-            :validations => [v_positive(:note)],
-            :modulatable => false,
-            :midi => true
-          },
-          :amp =>
+      def specific_arg_info
+        {
+          :click =>
           {
-            :doc => "The amplitude of the sound. Typically a value between 0 and 1. Higher amplitudes may be used, but won't make the sound louder, they will just reduce the quality of all the sounds currently being played (due to compression.)",
-            :validations => [v_positive(:amp)],
+            :doc => "Amount of initial click to the rimshot sound. 0 is no click and 1 is a hard click.",
+            :validations => [v_between_inclusive(:click, 0, 1)],
             :modulatable => false
           },
-          :pan =>
+          :decay =>
           {
-            :doc => "Position of sound in stereo. With headphones on, this means how much of the sound is in the left ear, and how much is in the right ear. With a value of -1, the sound is completely in the left ear, a value of 0 puts the sound equally in both ears and a value of 1 puts the sound in the right ear. Values in between -1 and 1 move the sound accordingly.",
-            :validations => [v_between_inclusive(:pan, -1, 1)],
+            :doc => "Amount of decay for the rimshot. Higher numbers increase the decay duration.",
+            :validations => [v_positive_not_zero(:decay)],
             :modulatable => false
           },
-        })
-      end
-
-      def specific_arg_info
-        {
-          :note2 =>
+          :detune =>
           {
-            :doc => "Second base frequency of the sound. Play with both both `:note` and `:note2` for slight changes of timbre and, of course, pitch.",
-            :validations => [v_positive(:note2)],
-            :modulatable => false,
-            :midi => true
+            :doc => "Detune in MIDI notes of original pitch for the rimshot's timbre.",
+            :validations => [v_positive_not_zero(:detune)],
+            :modulatable => false
           },
-          :cutoff_lo =>
+          :decay_curve =>
           {
-            :doc => "MIDI note representing the lowest frequencies allowed to be present in the sound.",
-            :validations => [v_positive(:cutoff_lo)],
+            :doc => "Curve value for the decay of the tom",
+            :validations => [],
             :modulatable => false
           },
-          :cutoff_hi =>
+          :lpf =>
           {
-            :doc => "MIDI note representing the highest frequencies allowed to be present in the sound.",
-            :validations => [v_positive(:cutoff_hi)],
-            :modulatable => false
+            :doc => "Low pass filter cutoff value for the rimshot. A MIDI note representing the highest frequencies allowed to be present in the sound. A low value like 30 makes the sound round and dull, a high value like 100 makes the sound buzzy and crispy.",
+            :validations => [v_positive(:lpf), v_less_than(:lpf, 131)],
+            :modulatable => true,
+            :midi => true
           },
+          :hpf =>
+          {
+            :doc => "High pass filter cutoff value for the rimshot. A MIDI note representing the lowest frequencies allowed to be present in the sound. A high value like 100 makes the sound thin and whispy, a low value like 40 removes just the lower bass components of the sound.",
+            :validations => [v_positive(:hpf), v_less_than(:hpf, 119)],
+            :modulatable => true,
+            :midi => true
+          }
         }
       end
     end

etc/synthdefs/compiled/sonic-pi-sc808_rimshot.scsyndef

@@ -327,35 +327,48 @@ SynthDef('sonic-pi-sc808_congahi', {|
 }).writeDefFile("/Users/sam/Development/sonic-pi/etc/synthdefs/compiled/");
 )
 
-
+(
 SynthDef('sonic-pi-sc808_rimshot', {|
   note = 92,
-  note2 = 70,
-  amp = 1,
-  pan = 0,
-  cutoff_lo = 63,
-  cutoff_hi = 118,
+  detune = -22,
+  amp = 1, amp_slide = 0, amp_slide_shape = 1, amp_slide_curve = 0,
+  pan = 0, pan_slide = 0, pan_slide_shape = 1, pan_slide_curve = 0,
+  hpf = 63, hpf_slide = 0, hpf_slide_shape = 1, hpf_slide_curve = 1,
+  lpf = 118, lpf_slide = 0, lpf_slide_shape = 1, lpf_slide_curve = 1,
+  decay = 0.07,
+  decay_curve = -42,
+  click = 1,
   out_bus = 0|
 
-  var env, sig, punch, tri1, tri2;
+  var env, sig, punch, tri1, tri2, note2;
 
+  note2 = note + detune;
   note = note.midicps;
   note2 = note2.midicps;
-  cutoff_lo = cutoff_lo.midicps;
-  cutoff_hi = cutoff_hi.midicps;
 
-  env = EnvGen.kr(Env.new([1, 1, 0], [0.00272, 0.07], -42), doneAction:2);
+  lpf = lpf.midicps;
+  hpf = hpf.midicps;
+
+  amp = amp.varlag(amp_slide, amp_slide_curve, amp_slide_shape);
+  pan = pan.varlag(pan_slide, pan_slide_curve, pan_slide_shape);
+  hpf = hpf.varlag(hpf_slide, hpf_slide_curve, hpf_slide_shape);
+  lpf = lpf.varlag(lpf_slide, lpf_slide_curve, lpf_slide_shape);
+
+  env = EnvGen.kr(Env.new([click, 1, 0], [0.00272, decay], decay_curve), doneAction:2);
   tri1 = LFTri.ar(note * 1.1, 1) * env;
   tri2 = LFPulse.ar(note2 * 1.1, width:0.8) * env;
   punch = WhiteNoise.ar * env * 0.46;
   sig = tri1 + tri2 + punch;
   sig = BPeakEQ.ar(sig, 464, 0.44, 8);
-  sig = HPF.ar(sig, cutoff_lo);
-  sig = LPF.ar(sig, cutoff_hi);
-  sig = Pan2.ar(sig * amp, pan);
-  Out.ar(out_bus, sig);
+  sig = HPF.ar(sig, hpf);
+  sig = LPF.ar(sig, lpf);
+  sig = sig * amp;
+  DetectSilence.ar(sig, doneAction: Done.freeSelf);
+  Out.ar(out_bus, Pan2.ar(sig, pan));
+
+}).writeDefFile("/Users/sam/Development/sonic-pi/etc/synthdefs/compiled/");
+)
 
-}).writeDefFile("/Users/sam/Development/RPi/sonic-pi/etc/synthdefs/compiled/");
 
 SynthDef('sonic-pi-sc808_claves', {|