Synths - fix up sc808 closed hihat

Author: samaaron

app/server/ruby/lib/sonicpi/synths/synthinfo.rb

@@ -4579,41 +4579,32 @@ def synth_name
         "sc808_closed_hihat"
       end
 
-      def on_start(studio, args_h)
-        args_h[:rand_buf] = studio.rand_buf_id
-      end
-
       def doc
         "Closed hi-hat of the SC808 drum machine based on [Yoshinosuke Horiuchi's](https://www.patreon.com/4H/posts) implementation of the legendary rhythm composer from the early 80s. This is a percussive synth, so it does not use the standard envelope parameters, neither does it feature slideable parameters."
       end
 
       def arg_defaults
         {
           :amp => 1,
+          :amp_slide => 0,
+          :amp_slide_shape => 1,
+          :amp_slide_curve => 0,
           :pan => 0,
-          :decay => 0.42,
-          :cutoff_lo => 121.05875888638981,
-          :cutoff_hi => 121.25219487074914,
+          :pan_slide => 0,
+          :pan_slide_shape => 1,
+          :pan_slide_curve => 0,
+          :hpf => 121.252,
+          :hpf_slide => 0,
+          :hpf_slide_shape => 1,
+          :hpf_slide_curve => 0,
+          :lpf => 121.0588,
+          :lpf_slide => 0,
+          :lpf_slide_shape => 1,
+          :lpf_slide_curve => 0,
+          :decay => 0.42
         }
       end
 
-      def default_arg_info
-        super.merge({
-          :amp =>
-          {
-            :doc => "The amplitude of the sound. Typically a value between 0 and 1. Higher amplitudes may be used, but won't make the sound louder, they will just reduce the quality of all the sounds currently being played (due to compression.)",
-            :validations => [v_positive(:amp)],
-            :modulatable => false
-          },
-          :pan =>
-          {
-            :doc => "Position of sound in stereo. With headphones on, this means how much of the sound is in the left ear, and how much is in the right ear. With a value of -1, the sound is completely in the left ear, a value of 0 puts the sound equally in both ears and a value of 1 puts the sound in the right ear. Values in between -1 and 1 move the sound accordingly.",
-            :validations => [v_between_inclusive(:pan, -1, 1)],
-            :modulatable => false
-          },
-        })
-      end
-
       def specific_arg_info
         {
           :decay =>
@@ -4622,18 +4613,21 @@ def specific_arg_info
             :validations => [v_positive(:decay)],
             :modulatable => false
           },
-          :cutoff_lo =>
+          :lpf =>
           {
-            :doc => "MIDI note representing the lowest frequencies allowed during sound generation. The effect may be unexpected: fiddling with the cutoffs produces a variety of tin sounds.",
-            :validations => [v_positive(:cutoff_lo)],
-            :modulatable => false
+            :doc => "Low pass filter cutoff value for the hi-hat. A MIDI note representing the highest frequencies allowed to be present in the sound. A low value like 30 makes the sound round and dull, a high value like 100 makes the sound buzzy and crispy.",
+            :validations => [v_positive(:lpf), v_less_than(:lpf, 131)],
+            :modulatable => true,
+            :midi => true
           },
-          :cutoff_hi =>
+          :hpf =>
           {
-            :doc => "MIDI note representing the highest frequencies allowed during sound generation. The effect may be unexpected: fiddling with the cutoffs produces a variety of tin sounds.",
-            :validations => [v_positive(:cutoff_hi)],
-            :modulatable => false
-          },
+            :doc => "High pass filter cutoff value for the rimshot. A MIDI note representing the lowest frequencies allowed to be present in the sound. A high value like 100 makes the sound thin and whispy, a low value like 40 removes just the lower bass components of the sound.",
+            :validations => [v_positive(:hpf), v_less_than(:hpf, 131)],
+            :modulatable => true,
+            :midi => true
+          }
+
         }
       end
     end

etc/synthdefs/compiled/sonic-pi-sc808_closed_hihat.scsyndef

@@ -465,20 +465,23 @@ SynthDef('sonic-pi-sc808_cowbell', {|
 }).writeDefFile("/Users/sam/Development/sonic-pi/etc/synthdefs/compiled/");
 )
 
+(
 SynthDef('sonic-pi-sc808_closed_hihat', {|
 
-  amp = 1,
-  pan = 0,
-  decay=0.42,
-  cutoff_lo = 121.05875888638981,
-  cutoff_hi = 121.25219487074914,
+  amp = 1, amp_slide = 0, amp_slide_shape = 1, amp_slide_curve = 0,
+  pan = 0, pan_slide = 0, pan_slide_shape = 1, pan_slide_curve = 0,
+  hpf = 121.25219487074914, hpf_slide = 0, hpf_slide_shape = 1, hpf_slide_curve = 1,
+  lpf = 121.05875888638981, lpf_slide = 0, lpf_slide_shape = 1, lpf_slide_curve = 1,
 
+  decay=0.42,
   out_bus = 0|
 
   var sig, sighi,siglow, sum, env, osc1, osc2, osc3, osc4, osc5, osc6;
 
-  cutoff_lo = cutoff_lo.midicps;
-  cutoff_hi = cutoff_hi.midicps;
+  hpf = hpf.midicps;
+  lpf = lpf.midicps;
+  hpf = hpf.varlag(hpf_slide, hpf_slide_curve, hpf_slide_shape);
+  lpf = lpf.varlag(lpf_slide, lpf_slide_curve, lpf_slide_shape);
 
   env = EnvGen.kr(Env.perc(0.005, decay, 1, -30),doneAction:2);
   osc1 = LFPulse.ar(203.52);
@@ -488,17 +491,18 @@ SynthDef('sonic-pi-sc808_closed_hihat', {|
   osc5 = LFPulse.ar(811.16);
   osc6 = LFPulse.ar(538.75);
   sighi = (osc1 + osc2 + osc3 + osc4 + osc5 + osc6);
-    siglow = (osc1 + osc2 + osc3 + osc4 + osc5 + osc6);
-    sighi = BPF.ar(sighi, cutoff_lo, 1);
-    sighi = HPF.ar(sighi, cutoff_hi);
-    siglow = BBandPass.ar(siglow, 8900, 0.8);
-    siglow = BHiPass.ar(siglow, 9000, 0.3);
-    sig = BPeakEQ.ar((siglow+sighi), 9700, 0.8, 0.7);
-    sig = sig * env * amp * 12;
-
+  siglow = (osc1 + osc2 + osc3 + osc4 + osc5 + osc6);
+  sighi = BPF.ar(sighi, lpf, 1);
+  sighi = HPF.ar(sighi, hpf);
+  siglow = BBandPass.ar(siglow, 8900, 0.8);
+  siglow = BHiPass.ar(siglow, 9000, 0.3);
+  sig = BPeakEQ.ar((siglow+sighi), 9700, 0.8, 0.7);
+  sig = sig * env * amp * 12;
+  DetectSilence.ar(sig, doneAction: Done.freeSelf);
   Out.ar(out_bus, Pan2.ar(sig, pan));
 
-}).writeDefFile("/Users/sam/Development/RPi/sonic-pi/etc/synthdefs/compiled/");
+}).writeDefFile("/Users/sam/Development/sonic-pi/etc/synthdefs/compiled/");
+)
 
 SynthDef('sonic-pi-sc808_open_hihat', {|