Synths - fix up sc808-cowbell

Author: samaaron

app/server/ruby/lib/sonicpi/synths/synthinfo.rb

@@ -4456,7 +4456,7 @@ def arg_defaults
           :hpf => 113,
           :hpf_slide => 0,
           :hpf_slide_shape => 1,
-          :hpf_slide_curve => 0
+          :hpf_slide_curve => 0,
           :click => 1,
           :decay => 0.1,
           :decay_curve => -20
@@ -4510,70 +4510,58 @@ def synth_name
         "sc808_cowbell"
       end
 
-      def on_start(studio, args_h)
-        args_h[:rand_buf] = studio.rand_buf_id
-      end
-
       def doc
         "Cowbell of the SC808 drum machine based on [Yoshinosuke Horiuchi's](https://www.patreon.com/4H/posts) implementation of the legendary rhythm composer from the early 80s. This is a percussive synth, so it does not use the standard envelope parameters, neither does it feature slideable parameters."
       end
 
       def arg_defaults
         {
-          :note => 79.58979585613574,
+          :note => 79.59,
+          :detune => -7.084,
           :amp => 1,
+          :amp_slide => 0,
+          :amp_slide_shape => 1,
+          :amp_slide_curve => 0,
           :pan => 0,
-          :note2 => 72.50534928521387,
-          :cutoff_lo => 59,
-          :cutoff_hi => 109,
+          :pan_slide => 0,
+          :pan_slide_shape => 1,
+          :pan_slide_curve => 0,
+          :hpf => 113,
+          :hpf_slide => 0,
+          :hpf_slide_shape => 1,
+          :hpf_slide_curve => 0,
+          :decay => 9.5,
+          :decay_curve => -90
         }
       end
 
-      def default_arg_info
-        super.merge({
-          :note =>
-          {
-            :doc => "Note to play. Either a MIDI number or a symbol representing a note. For example: `30`, `52`, `:C`, `:C2`, `:Eb4`, or `:Ds3`",
-            :validations => [v_positive(:note)],
-            :modulatable => false,
-            :midi => true
-          },
-          :amp =>
-          {
-            :doc => "The amplitude of the sound. Typically a value between 0 and 1. Higher amplitudes may be used, but won't make the sound louder, they will just reduce the quality of all the sounds currently being played (due to compression.)",
-            :validations => [v_positive(:amp)],
-            :modulatable => false
-          },
-          :pan =>
-          {
-            :doc => "Position of sound in stereo. With headphones on, this means how much of the sound is in the left ear, and how much is in the right ear. With a value of -1, the sound is completely in the left ear, a value of 0 puts the sound equally in both ears and a value of 1 puts the sound in the right ear. Values in between -1 and 1 move the sound accordingly.",
-            :validations => [v_between_inclusive(:pan, -1, 1)],
-            :modulatable => false
-          },
-        })
-      end
-
       def specific_arg_info
         {
-          :note2 =>
+          :detune =>
           {
-            :doc => "Second base frequency of the sound. Play with both both `:note` and `:note2` for slight changes of timbre and, of course, pitch.",
-            :validations => [v_positive(:note2)],
-            :modulatable => false,
-            :midi => true
+            :doc => "Distance (in MIDI notes) between components of sound. Affects thickness, sense of tuning and harmony. Tiny values such as 0.1 create a thick sound. Larger values such as 0.5 make the tuning sound strange. Even bigger values such as 5 create chord-like sounds.",
+            :validations => [],
+            :modulatable => true
           },
-          :cutoff_lo =>
+          :decay =>
           {
-            :doc => "MIDI note representing the lowest frequencies allowed to be present in the sound.",
-            :validations => [v_positive(:cutoff_lo)],
+            :doc => "Amount of decay for the cowbell. Higher numbers increase the decay duration.",
+            :validations => [v_positive_not_zero(:decay)],
             :modulatable => false
           },
-          :cutoff_hi =>
+          :decay_curve =>
           {
-            :doc => "MIDI note representing the highest frequencies allowed to be present in the sound.",
-            :validations => [v_positive(:cutoff_hi)],
+            :doc => "Curve value for the decay of the cowbell",
+            :validations => [],
             :modulatable => false
           },
+          :hpf =>
+          {
+            :doc => "High pass filter cutoff value for the cowbell. A MIDI note representing the lowest frequencies allowed to be present in the sound. A high value like 100 makes the sound thin and whispy, a low value like 40 removes just the lower bass components of the sound.",
+            :validations => [v_positive(:hpf), v_less_than(:hpf, 119)],
+            :modulatable => true,
+            :midi => true
+          }
         }
       end
     end

etc/synthdefs/compiled/sonic-pi-sc808_cowbell.scsyndef

@@ -425,37 +425,42 @@ SynthDef('sonic-pi-sc808_maracas', {|
 
 }).writeDefFile("/Users/sam/Development/sonic-pi/etc/synthdefs/compiled/");
 
+(
 SynthDef('sonic-pi-sc808_cowbell', {|
 
   note = 79.58979585613574,
-  note2 = 72.50534928521387,
-  amp = 1,
-  pan = 0,
-  cutoff_lo = 59,
-  cutoff_hi = 109,
-
+  detune = -7.08444657092187
+  amp = 1, amp_slide = 0, amp_slide_shape = 1, amp_slide_curve = 0,
+  pan = 0, pan_slide = 0, pan_slide_shape = 1, pan_slide_curve = 0,
+  hpf = 59, hpf_slide = 0, hpf_slide_shape = 1, hpf_slide_curve = 1,
+  lpf = 109, lpf_slide = 0, lpf_slide_shape = 1, lpf_slide_curve = 1,
+  decay = 9.5,
+  decay_curve = -90,
   out_bus = 0|
 
-  var sig, pul1, pul2, env, atk, atkenv, datk;
-
+  var sig, pul1, pul2, env, atk, atkenv, datk, note2;
+  note2 = note + detune;
   note = note.midicps;
   note2 = note2.midicps;
-  cutoff_lo = cutoff_lo.midicps;
-  cutoff_hi = cutoff_hi.midicps;
+  hpf = hpf.midicps;
+  lpf = lpf.midicps;
+  hpf = hpf.varlag(hpf_slide, hpf_slide_curve, hpf_slide_shape);
+  lpf = lpf.varlag(lpf_slide, lpf_slide_curve, lpf_slide_shape);
 
   atkenv = EnvGen.kr(Env.perc(0, 1, 1, -215),doneAction:0);
-  env = EnvGen.kr(Env.perc(0.01, 9.5, 1, -90),doneAction:2);
+  env = EnvGen.kr(Env.perc(0.01, decay, 1, decay_curve),doneAction:2);
   pul1 = LFPulse.ar(note);
   pul2 = LFPulse.ar(note2);
   atk = (pul1 + pul2) * atkenv * 6;
   datk = (pul1 + pul2) * env;
   sig = (atk + datk) * amp / 6;
-  sig = HPF.ar(sig, cutoff_lo);
-  sig = LPF.ar(sig, cutoff_hi);
-
+  sig = HPF.ar(sig, hpf);
+  sig = LPF.ar(sig, lpf);
+  DetectSilence.ar(sig, doneAction: Done.freeSelf);
   Out.ar(out_bus, Pan2.ar(sig, pan));
 
-}).writeDefFile("/Users/sam/Development/RPi/sonic-pi/etc/synthdefs/compiled/");
+}).writeDefFile("/Users/sam/Development/sonic-pi/etc/synthdefs/compiled/");
+)
 
 SynthDef('sonic-pi-sc808_closed_hihat', {|