GUI - fix indent toggle

initially indention only happened on run, but more recently it also became part of hitting enter. Unfortunately the toggle wasn't updated to take into account this change. This commit fixes this and also communicates that auto-indent isn't just on run, but on hitting enter too.

Author: samaaron

app/gui/qt/mainwindow.cpp

@@ -2411,6 +2411,17 @@ void MainWindow::autoIndentOnRunMenuChanged()
 void MainWindow::changeAutoIndentOnRun()
 {
     QSignalBlocker blocker(autoIndentOnRunAct);
+    if(piSettings->auto_indent_on_run) {
+      statusBar()->showMessage(tr("Auto Indent mode enabled"), 2000);
+    } else {
+      statusBar()->showMessage(tr("Auto Indent mode disabled"), 2000);
+    }
+
+    for (int i = 0; i < editorTabWidget->count(); i++) {
+      SonicPiScintilla* ws = ((SonicPiEditor*)editorTabWidget->widget(i))->getWorkspace();
+      ws->setAutoIndentEnabled(piSettings->auto_indent_on_run);
+    }
+
     autoIndentOnRunAct->setChecked(piSettings->auto_indent_on_run);
 }
 
@@ -2881,7 +2892,7 @@ void MainWindow::createToolBar()
     clearOutputOnRunAct->setChecked(piSettings->log_cues);
     connect(clearOutputOnRunAct, SIGNAL(triggered()), this, SLOT(clearOutputOnRunMenuChanged()));
 
-    autoIndentOnRunAct = new QAction(tr("Auto Indent Code Buffer on Run"), this);
+    autoIndentOnRunAct = new QAction(tr("Auto Indent Code Buffer"), this);
     autoIndentOnRunAct->setCheckable(true);
     autoIndentOnRunAct->setChecked(piSettings->auto_indent_on_run);
     connect(autoIndentOnRunAct, SIGNAL(triggered()), this, SLOT(autoIndentOnRunMenuChanged()));

app/gui/qt/widgets/settingswidget.cpp

@@ -290,7 +290,7 @@ QGroupBox* SettingsWidget::createEditorPrefsTab() {
     automation_box->setToolTip(tr("Configure automation and other features."));
 
     auto_indent_on_run = new QCheckBox(tr("Auto-align"));
-    auto_indent_on_run->setToolTip(tr("Automatically align code on Run"));
+    auto_indent_on_run->setToolTip(tr("Automatically align code on Enter or Run "));
 
     show_line_numbers = new QCheckBox(tr("Show line numbers"));
     show_line_numbers->setToolTip(tr("Toggle line number visibility."));

app/gui/qt/widgets/sonicpiscintilla.cpp

@@ -684,3 +684,7 @@ void SonicPiScintilla::showAutoCompletion(bool val) {
 void SonicPiScintilla::setText(const QString &text) {
   SendScintilla(SCI_SETTEXT, ScintillaBytesConstData(textAsBytes(text)));
 }
+
+void SonicPiScintilla::setAutoIndentEnabled(bool enabled) {
+  this->autoIndent = enabled;
+}

app/gui/qt/widgets/sonicpiscintilla.h

@@ -77,6 +77,7 @@ class SonicPiScintilla : public QsciScintilla
     void replaceBuffer(QString content, int line, int index, int first_line);
     void newlineAndIndent();
     void completeListOrNewlineAndIndent();
+    void setAutoIndentEnabled(bool enabled);
 
     void sp_paste();
     void sp_cut();