GUI - make goto buffer shortcuts standard and remove pref to disable them

Author: samaaron

app/gui/qt/mainwindow.cpp

@@ -3074,7 +3074,6 @@ void MainWindow::readSettings() {
     piSettings->show_scopes = settings.value("prefs/scope/show-scopes", true).toBool();
     piSettings->show_scope_labels = settings.value("prefs/scope/show-labels", false).toBool();
     piSettings->show_cues = settings.value("prefs/show_cues", true).toBool();
-    piSettings->goto_buffer_shortcuts = settings.value("prefs/goto_buffer_shortcuts", false).toBool();
     QString styleName = settings.value("prefs/theme", "").toString();
     piSettings->themeStyle = theme->themeNameToStyle(styleName);
     piSettings->show_autocompletion = settings.value("prefs/show-autocompletion", true).toBool();
@@ -3123,7 +3122,6 @@ void MainWindow::writeSettings()
     settings.setValue("prefs/scope/show-labels", piSettings->show_scope_labels );
     settings.setValue("prefs/scope/show-scopes", piSettings->show_scopes );
     settings.setValue("prefs/show_cues", piSettings->show_cues);
-    settings.setValue("prefs/goto_buffer_shortcuts", piSettings->goto_buffer_shortcuts);
     settings.setValue("prefs/theme", theme->themeStyleToName(piSettings->themeStyle));
 
     settings.setValue("prefs/show-autocompletion", piSettings->show_autocompletion);
@@ -3384,11 +3382,8 @@ void MainWindow::tabPrev() {
 }
 
 void MainWindow::tabGoto(int index) {
-    if (!piSettings->goto_buffer_shortcuts)
-        return;
-
-    if (index < tabs->count())
-        QMetaObject::invokeMethod(tabs, "setCurrentIndex", Q_ARG(int, index));
+  if (index < tabs->count())
+    QMetaObject::invokeMethod(tabs, "setCurrentIndex", Q_ARG(int, index));
 }
 
 void MainWindow::setLineMarkerinCurrentWorkspace(int num) {

app/gui/qt/widgets/settingswidget.cpp

@@ -304,8 +304,6 @@ QGroupBox* SettingsWidget::createEditorPrefsTab() {
     show_tabs->setToolTip(tr("Toggle visibility of the buffer selection tabs."));
     full_screen = new QCheckBox(tr("Full screen"));
     full_screen->setToolTip(tooltipStrShiftMeta('F', tr("Toggle full screen mode.")));
-    goto_buffer_shortcuts = new QCheckBox(tr("Enable buffer shortcuts"));
-    goto_buffer_shortcuts->setToolTip(tr("Use C-M-0 .. C-M-9 to go to buffer directly"));
 
     colourModeButtonGroup = new QButtonGroup(this);
     lightModeCheck = new QCheckBox(tr("Light"));
@@ -342,7 +340,7 @@ QGroupBox* SettingsWidget::createEditorPrefsTab() {
 
     automation_box_layout->addWidget(auto_indent_on_run);
     automation_box_layout->addWidget(full_screen);
-    automation_box_layout->addWidget(goto_buffer_shortcuts);
+
     automation_box->setLayout(automation_box_layout);
 
     QGroupBox *debug_box = new QGroupBox(tr("Logging"));
@@ -657,7 +655,6 @@ void SettingsWidget::updateSettings() {
     piSettings->show_buttons = show_buttons->isChecked();
     piSettings->show_tabs = show_tabs->isChecked();
     piSettings->full_screen = full_screen->isChecked();
-    piSettings->goto_buffer_shortcuts = goto_buffer_shortcuts->isChecked();
     piSettings->log_synths = log_synths->isChecked();
     piSettings->clear_output_on_run = clear_output_on_run->isChecked();
     piSettings->log_cues = log_cues->isChecked();
@@ -697,7 +694,6 @@ void SettingsWidget::settingsChanged() {
     show_buttons->setChecked(piSettings->show_buttons);
     show_tabs->setChecked(piSettings->show_tabs);
     full_screen->setChecked(piSettings->full_screen);
-    goto_buffer_shortcuts->setChecked(piSettings->goto_buffer_shortcuts);
     log_synths->setChecked(piSettings->log_synths);
     clear_output_on_run->setChecked(piSettings->clear_output_on_run);
     log_cues->setChecked(piSettings->log_cues);
@@ -743,7 +739,6 @@ void SettingsWidget::connectAll() {
     connect(show_buttons, SIGNAL(clicked()), this, SLOT(updateSettings()));
     connect(show_tabs, SIGNAL(clicked()), this, SLOT(updateSettings()));
     connect(full_screen, SIGNAL(clicked()), this, SLOT(updateSettings()));
-    connect(goto_buffer_shortcuts, SIGNAL(clicked()), this, SLOT(updateSettings()));
     connect(log_synths, SIGNAL(clicked()), this, SLOT(updateSettings()));
     connect(clear_output_on_run, SIGNAL(clicked()), this, SLOT(updateSettings()));
     connect(log_cues, SIGNAL(clicked()), this, SLOT(updateSettings()));