GUI - Show an error message when the selected language fails to load, and add a warning about stopping runs & recordings (due to restart) when changing language.

Author: SunderB

app/gui/qt/mainwindow.cpp

@@ -301,6 +301,11 @@ MainWindow::MainWindow(QApplication& app, QSplashScreen* splash)
     toggleOSCServer(1);
 
     app.setActiveWindow(tabs->currentWidget());
+
+    if (!i18n) {
+      showLanguageLoadingError();
+    }
+
     showWelcomeScreen();
 }
 
@@ -1628,6 +1633,18 @@ void MainWindow::startupError(QString msg)
 #endif
 }
 
+void MainWindow::showLanguageLoadingError() {
+  QMessageBox msgBox(this);
+  msgBox.setIcon(QMessageBox::Warning);
+  msgBox.setText(QString(tr("Failed to load translations for language: %1")).arg(sonicPii18n->getNativeLanguageName(this->ui_language)));
+  msgBox.setInformativeText(tr("Falling back to English. Sorry about this.") + "\n" + tr("Please consider reporting a bug at") + "\nhttp://github.com/sonic-pi-net/sonic-pi/issues");
+
+  QPushButton *okButton = msgBox.addButton(tr("OK"), QMessageBox::AcceptRole);
+  msgBox.setDefaultButton(okButton);
+
+  msgBox.exec();
+}
+
 void MainWindow::replaceBuffer(QString id, QString content, int line, int index, int first_line)
 {
     SonicPiScintilla* ws = filenameToWorkspace(id.toStdString());

app/gui/qt/mainwindow.h

@@ -239,6 +239,7 @@ class MainWindow : public QMainWindow
         void splashClose();
         void setMessageBoxStyle();
         void startupError(QString msg);
+        void showLanguageLoadingError();
         void tabNext();
         void tabPrev();
         void tabGoto(int index);

app/gui/qt/widgets/settingswidget.cpp

@@ -556,7 +556,7 @@ void SettingsWidget::updateUILanguage(int index) {
 
         QMessageBox msgBox(this);
         msgBox.setText(QString(tr("You've selected a new language: %1")).arg(new_lang));
-        msgBox.setInformativeText(tr("Do you want to apply this language?\nApplying the new language will restart Sonic Pi."));
+        msgBox.setInformativeText(tr("Do you want to apply this language?") + "\n" + tr("Applying the new language will stop any current runs & recordings, and restart Sonic Pi."));
         QPushButton *restartButton = msgBox.addButton(tr("Apply and Restart"), QMessageBox::ActionRole);
         QPushButton *dismissButton = msgBox.addButton(tr("Cancel"), QMessageBox::RejectRole);
         msgBox.setDefaultButton(restartButton);