Check if a child dependency was already included as compileOnly (#162)

guillermo-varela · web-flow · commit 063a01b48557 · 2024-08-15T23:53:00.000-05:00
diff --git a/src/main/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinder.java b/src/main/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinder.java
@@ -429,7 +429,9 @@ private boolean shouldRemoveCompileOnlyDependencies(Project project, Configurati
   }
 
   private void fillAllChildDependencies(ResolvedDependency resolvedDependency, Set<String> dependenciesIds) {
-    dependenciesIds.add(getResolvedDependencyId(resolvedDependency));
+    if (!dependenciesIds.add(getResolvedDependencyId(resolvedDependency))) {
+      return;
+    }
 
     if (resolvedDependency.getChildren() != null) {
       for (ResolvedDependency child : resolvedDependency.getChildren()) {

Original file line number	Diff line number	Diff line change
`@@ -429,7 +429,9 @@ private boolean shouldRemoveCompileOnlyDependencies(Project project, Configurati`
`429`	`429`	`}`
`430`	`430`
`431`	`431`	`private void fillAllChildDependencies(ResolvedDependency resolvedDependency, Set<String> dependenciesIds) {`
`432`		`- dependenciesIds.add(getResolvedDependencyId(resolvedDependency));`
	`432`	`+ if (!dependenciesIds.add(getResolvedDependencyId(resolvedDependency))) {`
	`433`	`+ return;`
	`434`	`+ }`
`433`	`435`
`434`	`436`	`if (resolvedDependency.getChildren() != null) {`
`435`	`437`	`for (ResolvedDependency child : resolvedDependency.getChildren()) {`