Daily Repeat - End Date Not Respected

[BrandonJamesBorders]

Describe the bug or issue you're experiencing
When having an event repeat daily, the end date is not respected.

Steps to reproduce

1. Create a new event.
2. Set it to repeat daily.
3. Set an end date.
4. Observe that the event occurrences initially has 100 events, even when setting the end date to the next day.

Video overview: https://www.loom.com/share/b5b0fc1dc0ac4cfe89fd01bc401dbca6

Expected behavior
Have the appropriate number of occurrences in the entry.

Craft & Plugin Info (please complete the following information):

• Craft Version: 4.13.8
• Calendar Version: 5.0.13
• Calendar Edition: Pro
• Fresh Install or Upgrade: Fresh

Additional context

[kjmartens]

Hi @BrandonJamesBorders,

Sorry for the delay...

Did you end up figuring this one out? I can't duplicate this behavior on my end, but I will have a developer take a look and see if they have any ideas about what might be happening here. 🙂

[seandelaney]

I cannot replicate.

I created a test event:

Month shows event stopping on end date:

You scroll very fast in the video when showing your code, so near impossible to work out whats happening in the code without seeing the actual file itself!

I suspect you have something misconfigured when creating events and this is causing an issue. But as you can see, a simple test in the CP shows functionality working as expected.

[BrandonJamesBorders]

Thanks for looking into this @seandelaney. I created a simpler example that is less prone to having issues introduced from my customization. Additionally the events does get "cleaned" after save, the issue is inconsistency in the occurrences object.

Another loom: https://www.loom.com/share/49205ded61d048e399d0c1b599e50769

Setup

1. Fresh install of Craft CMS 4.13.10
2. Fresh install of Calendar Pro 5.0.13
3. New Module php craft make module
4. Add a listener for EventsService::EVENT_AFTER_SAVE

private function attachEventHandlers(): void
{
    // Register event handlers here ...
    // (see https://craftcms.com/docs/4.x/extend/events.html to get started)
    Event::on(
        EventsService::class,
        EventsService::EVENT_AFTER_SAVE,
        function (SaveElementEvent $event) {
            $element = $event->element;
            $occurrences = $element->occurrences ?? null;
            dd($occurrences);
        }
    );
}

5. Output occurrences

Replication Notes

1. If I create an event that repeats daily starting today and ending three days later, I get three occurrences as expected.
2. If I create an event that repeats daily starting in the future and ending three days later, I get occurrences from today until the occurrence end date.