Skip to content

[Content]: installation for deno is incorrect #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MonstraG opened this issue Mar 29, 2025 · 2 comments · Fixed by #1152
Closed

[Content]: installation for deno is incorrect #1148

MonstraG opened this issue Mar 29, 2025 · 2 comments · Fixed by #1152
Assignees
Labels
bug Something isn't working

Comments

@MonstraG
Copy link

📚 Subject area/topic

Installation

📋 Page(s) affected (or suggested, for new content)

https://docs.solidjs.com/solid-start/getting-started

📋 Description of content that is out-of-date or incorrect

This page says

deno run -A npm:solid@latest

But this will attempt to run 13-year-old solid npm package and that will fail.

It should have been

deno run -A npm:create-solid@latest

Other package managers (e.g. pnpm) seem to have create command that auto-prefixes with create- but deno doesn't seem to have one.

In fact, home page got it right! solidjs/solid-start#1663

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

@MonstraG MonstraG added the pending review Awaiting review by team members. label Mar 29, 2025
@MonstraG
Copy link
Author

The bad codeblock is

**1. Install SolidStart**
Once you have created a directory for your new application, you can initialize SolidStart with the following command:
```package-create
solid@latest
```

Before I've seen the block this felt as one of those very simple single line prs, but I have no clue what magic does package-create contain or where it comes from, and googling doesn't help

@amirhhashemi
Copy link
Collaborator

amirhhashemi commented Mar 31, 2025

@MonstraG Thank you for reporting this bug.

The ```package-* syntax is provided by SolidBase to reduce the boilerplate code for creating a command for multiple package managers. In the below line we have defined what ```package-create translates to for Deno (:content is replaced with the content of the markdown block):

create: "deno run -A npm::content",

I created a PR to fix it #1152

@amirhhashemi amirhhashemi added bug Something isn't working and removed pending review Awaiting review by team members. labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants