delta-push adds all workflows to the package

[pcon]

It appears that delta-push adds all the .workflow files to package regardless of if they have been changed or not.

This is a problem because if you have outbound messages in a workflow, the queue becomes paused during a deployment (even during a quick-deploy)

[sfloess]

Note to self - when testing don't use the XSLT.

[sfloess]

@pcon - this is odd...something is wonky with the dir-diff macro-def. I grabbed a sample workflow file and applied meld using what would be pushed (via sf.dryRun) and what is present: meld reports no diff.

Keep in mind, this is my using cached-delta-push.

Anyway, I'm on it...

[sfloess]

@pcon - which xslt(s) for workflows should be ignored? Outgoing_Message__c_pull.xsl ???? Or all?

[solenopsis-bot]

It was the case.workflow. The xslt strips out outbound message

…

On Sat, May 12, 2018, 10:02 Scot P. Floess ***@***.***> wrote: @pcon <https://github.com/pcon> - which xslt for workflows should be ignored? Outgoing_Message__c_pull.xsl ???? Or all? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#261 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKH3PzO4c9ys4Ejsj59HFSk1GN7V2IeWks5txuttgaJpZM4TQhuK> .

[sfloess]

@pcon - ack...lemme try to figure this out 👍

[sfloess]

@pcon - I'm confused as I did a pull from dev and the pulled Case.workflow is missing the Outbound element...whereas in git it's there...am I misunderstanding?

[solenopsis-bot]

We remove it from the workflow file via the xslt because of this issue.

…

On Sat, May 12, 2018, 11:06 Scot P. Floess ***@***.***> wrote: @pcon <https://github.com/pcon> - I'm confused as I did a pull from dev and the pulled Case.workflow is missing the Outbound element...whereas in git it's there...am I misunderstanding? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#261 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKH3P1-9RLCAoe0kFKyQE2cXIkMgovwJks5txvp5gaJpZM4TQhuK> .

[sfloess]

@pcon - so is the core issue related to package.xml and workflows being defined in it? I don't think I grok what is happening here. For example, if the Outbound element is removed on pull, but is exists in git, I'd expect the two files are different and will be included in the push

[solenopsis-bot]

I'll try to explain better later today. Worst case we can talk on Monday

…

On Sat, May 12, 2018, 11:12 Scot P. Floess ***@***.***> wrote: @pcon <https://github.com/pcon> - so is the core issue related to package.xml and workflows being defined in it? I don't think I grok what is happening here. For example, if the Outbound element is removed on pull, but is exiss in gut, I'd expect the two files are different and will be included in the push — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#261 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKH3P2DHO7sY5PMb6TVVPFUYpD9Irh5yks5txvvtgaJpZM4TQhuK> .

[sfloess]

@pcon - being that it's Mother's Day weekend, spend your time with the wife :) Monday is fine... I just feel bad I've neglected this project for so long lately :(

[pcon]

Here's the problem. If we run a delta-push and you inspect the workflows directory, you'll see that every workflow file is in there regardless of if it differs from the pull or not. I think that delta-push should only include files that differ in the zip. The reason I pointed out case.workflow is that is the primary one that is hurting us. It's probably easier to test with the others rather than with that one since it's being modified by an XSLT at the moment.