Skip to content

Commit d4c2522

Browse files
authored
chore(iOS): remove unused variables in modal updating function (#2960)
## Description The `newControllers` variable seems to be unused and there is no reason for it to exist. The variable has been added here: 80a4669#diff-1c3e13a1b0dcbaa5f7cff5f3ce12cc915fb509725faf693fb65cd23ceb49c4a9 Looks like somewhere along the way the logic was refactored but the variable was not removed. ## Changes Removed the unused variable. ## Test code and steps to reproduce I've done some sanity checks on `TestModalNavigation`. ## Checklist - [ ] Ensured that CI passes
1 parent 7c2a425 commit d4c2522

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

ios/RNSScreenStack.mm

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -421,9 +421,6 @@ - (void)setModalViewControllers:(NSArray<UIViewController *> *)controllers
421421

422422
_updatingModals = YES;
423423

424-
NSMutableArray<UIViewController *> *newControllers = [NSMutableArray arrayWithArray:controllers];
425-
[newControllers removeObjectsInArray:_presentedModals];
426-
427424
// We need to find bottom-most view controller that should stay on the stack
428425
// for the duration of transition.
429426

0 commit comments

Comments
 (0)