Skip to content

Commit 94c462b

Browse files
authored
Change eslint ban-types to warning. (#2714)
## Description While looking at #2711 we decided to change `P extends Record<string, unknown>` to `P extends object` (issue author already created #2712). However, current CI won't allow this change because of `ban-types` eslint rule. I've decided to follow @tjzel suggestion and change this rule to warning instead of error. ## Test plan Run `yarn lint:js-root`.
1 parent 35ec17d commit 94c462b

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.eslintrc.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,11 @@
1212
},
1313
"parser": "@typescript-eslint/parser",
1414
"parserOptions": {
15-
"project": ["./tsconfig.json", "./example/tsconfig.json", "./FabricExample/tsconfig.json"]
15+
"project": [
16+
"./tsconfig.json",
17+
"./example/tsconfig.json",
18+
"./FabricExample/tsconfig.json"
19+
]
1620
},
1721
"env": { "browser": true, "node": true, "jest/globals": true },
1822
"plugins": ["jest"],
@@ -32,6 +36,7 @@
3236
"@typescript-eslint/no-unsafe-call": "warn",
3337
"@typescript-eslint/no-unsafe-assignment": "warn",
3438
"@typescript-eslint/no-unsafe-return": "warn",
39+
"@typescript-eslint/ban-types": "warn",
3540

3641
// common
3742
"@typescript-eslint/explicit-module-boundary-types": "off",

0 commit comments

Comments
 (0)