Skip to content

Commit ed7e02d

Browse files
test: adapter.close() is now called by io.close()
Related: - socketio/socket.io@bf64870 - #9
1 parent 96dfc4a commit ed7e02d

File tree

3 files changed

+13
-32
lines changed

3 files changed

+13
-32
lines changed

package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/connection-state-recovery.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,7 @@ describe("connection state recovery", () => {
5858
});
5959

6060
afterEach(async () => {
61-
servers.forEach((server) => {
62-
// @ts-ignore
63-
server.httpServer.close();
64-
server.of("/").adapter.close();
65-
server.of("/foo").adapter.close();
66-
});
61+
servers.forEach((server) => server.close());
6762
await mongoClient.close();
6863
});
6964

@@ -267,12 +262,7 @@ describe("connection state recovery", () => {
267262
});
268263

269264
afterEach(async () => {
270-
servers.forEach((server) => {
271-
// @ts-ignore
272-
server.httpServer.close();
273-
server.of("/").adapter.close();
274-
server.of("/foo").adapter.close();
275-
});
265+
servers.forEach((server) => server.close());
276266
await mongoClient.close();
277267
});
278268

test/index.ts

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,8 @@ describe("@socket.io/mongodb-adapter", () => {
5757
});
5858

5959
afterEach(async () => {
60-
servers.forEach((server) => {
61-
// @ts-ignore
62-
server.httpServer.close();
63-
server.of("/").adapter.close();
64-
});
65-
clientSockets.forEach((socket) => {
66-
socket.disconnect();
67-
});
60+
servers.forEach((server) => server.close());
61+
clientSockets.forEach((socket) => socket.disconnect());
6862
await mongoClient.close();
6963
});
7064

@@ -85,10 +79,7 @@ describe("@socket.io/mongodb-adapter", () => {
8579
});
8680

8781
it("broadcasts to all clients in a namespace", (done) => {
88-
const partialDone = times(3, () => {
89-
servers.forEach((server) => server.of("/custom").adapter.close());
90-
done();
91-
});
82+
const partialDone = times(3, done);
9283

9384
servers.forEach((server) => server.of("/custom"));
9485

0 commit comments

Comments
 (0)