Skip to content

Commit f19a9e3

Browse files
chore: release 3.4.2
Diff: 3.4.1...3.4.2
1 parent d2daa28 commit f19a9e3

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## [3.4.2](https://github.com/socketio/engine.io-client/compare/3.4.1...3.4.2) (2020-05-13)
2+
3+
4+
15
## [3.4.1](https://github.com/socketio/engine.io-client/compare/3.4.0...3.4.1) (2020-04-17)
26

37

engine.io.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3101,6 +3101,13 @@ return /******/ (function(modules) { // webpackBootstrap
31013101
break;
31023102
}
31033103
}
3104+
3105+
// Remove event specific arrays for event types that no
3106+
// one is subscribed for to avoid memory leak.
3107+
if (callbacks.length === 0) {
3108+
delete this._callbacks['$' + event];
3109+
}
3110+
31043111
return this;
31053112
};
31063113

@@ -3114,9 +3121,14 @@ return /******/ (function(modules) { // webpackBootstrap
31143121

31153122
Emitter.prototype.emit = function(event){
31163123
this._callbacks = this._callbacks || {};
3117-
var args = [].slice.call(arguments, 1)
3124+
3125+
var args = new Array(arguments.length - 1)
31183126
, callbacks = this._callbacks['$' + event];
31193127

3128+
for (var i = 1; i < arguments.length; i++) {
3129+
args[i - 1] = arguments[i];
3130+
}
3131+
31203132
if (callbacks) {
31213133
callbacks = callbacks.slice(0);
31223134
for (var i = 0, len = callbacks.length; i < len; ++i) {

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "engine.io-client",
33
"description": "Client for the realtime Engine",
44
"license": "MIT",
5-
"version": "3.4.1",
5+
"version": "3.4.2",
66
"main": "lib/index.js",
77
"homepage": "https://github.com/socketio/engine.io-client",
88
"contributors": [

0 commit comments

Comments
 (0)