Ethernet test: Make interface detection dynamic, robustify bring-up and ping validation

- Add logic to auto-detect active Ethernet interface using ip/ipconfig
- Enhance bring-up sequence with retries and logging
- Improve ping test error handling and reporting
- Refactor for better CI diagnostics

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>

Author: smuppand

Runner/suites/Connectivity/Ethernet/run.sh

@@ -39,54 +39,53 @@ rm -f "$res_file"
 
 log_info "--------------------------------------------------------------------------"
 log_info "-------------------Starting $TESTNAME Testcase----------------------------"
- 
+
+# Check for dependencies
 check_dependencies ip ping
- 
-IFACE="eth0"
+
+# Detect Ethernet interface dynamically using helper
+IFACE=$(get_ethernet_interface)
+if [ -z "$IFACE" ]; then
+    log_fail "No Ethernet interface found!"
+    echo "$TESTNAME SKIP" > "$res_file"
+    exit 0
+fi
+log_info "Detected Ethernet interface: $IFACE"
+
 RETRIES=3
 SLEEP_SEC=3
- 
-# Check interface existence
-if ! ip link show "$IFACE" >/dev/null 2>&1; then
-    log_fail "Ethernet interface $IFACE not found"
-    echo "FAIL $TESTNAME" > "$res_file"
-    exit 1
-fi
- 
-# Bring up interface with retries
+
+# Bring up the interface with retries (always brings down first)
 log_info "Ensuring $IFACE is UP..."
-i=0
-while [ $i -lt $RETRIES ]; do
-    ip link set "$IFACE" up
-    sleep "$SLEEP_SEC"
-    if ip link show "$IFACE" | grep -q "state UP"; then
-        log_info "$IFACE is UP"
-        break
-    fi
-    log_warn "$IFACE is still DOWN (attempt $((i + 1))/$RETRIES)..."
-    i=$((i + 1))
-done
- 
-if [ $i -eq $RETRIES ]; then
+if ! bringup_interface "$IFACE" "$RETRIES" "$SLEEP_SEC"; then
     log_fail "Failed to bring up $IFACE after $RETRIES attempts"
-    echo "FAIL $TESTNAME" > "$res_file"
+    echo "$TESTNAME FAIL" > "$res_file"
     exit 1
 fi
- 
+log_pass "$IFACE is UP"
+
+# Log the current IP address (if any)
+IPADDR=$(get_ip_address "$IFACE")
+if [ -n "$IPADDR" ]; then
+    log_info "IP Address for $IFACE: $IPADDR"
+else
+    log_warn "Could not retrieve IP address for $IFACE"
+fi
+
 # Ping test with retries
 log_info "Running ping test to 8.8.8.8 via $IFACE..."
 i=0
 while [ $i -lt $RETRIES ]; do
     if ping -I "$IFACE" -c 4 -W 2 8.8.8.8 >/dev/null 2>&1; then
         log_pass "Ethernet connectivity verified via ping"
-        echo "PASS $TESTNAME" > "$res_file"
+        echo "$TESTNAME PASS" > "$res_file"
         exit 0
     fi
     log_warn "Ping failed (attempt $((i + 1))/$RETRIES)... retrying"
     sleep "$SLEEP_SEC"
     i=$((i + 1))
 done
- 
+
 log_fail "Ping test failed after $RETRIES attempts"
-echo "FAIL $TESTNAME" > "$res_file"
+echo "$TESTNAME FAIL" > "$res_file"
 exit 1

Runner/utils/functestlib.sh

@@ -391,3 +391,66 @@ weston_start() {
     fi
 }
 
+# Get the IPv4 address for a given interface
+get_ip_address() {
+    iface="$1"
+    if command -v ip >/dev/null 2>&1; then
+        ip -4 -o addr show "$iface" | awk '{print $4}' | cut -d/ -f1 | head -n1
+    elif command -v ifconfig >/dev/null 2>&1; then
+        ifconfig "$iface" 2>/dev/null | awk '/inet / {print $2}' | head -n1
+    fi
+}
+
+# Returns true (0) if interface is Ethernet type (type 1 in sysfs), false otherwise.
+is_ethernet_interface() {
+    iface="$1"
+    [ -f "/sys/class/net/$iface/type" ] && [ "$(cat "/sys/class/net/$iface/type")" = "1" ]
+}
+
+# Returns the names of all detected Ethernet interfaces (excluding loopback and common virtual types)
+get_ethernet_interfaces() {
+    for path in /sys/class/net/*; do
+        iface=$(basename "$path")
+        case "$iface" in
+            lo) continue ;;  # Loopback
+            docker*|br-*|veth*|virbr*|tap*|tun*|wlan*) continue ;;  # Common virtual & WiFi interfaces
+        esac
+        if is_ethernet_interface "$iface"; then
+            echo "$iface"
+        fi
+    done
+}
+
+# Returns the first detected Ethernet interface (or nothing if none found)
+get_ethernet_interface() {
+    get_ethernet_interfaces | head -n1
+}
+
+# Bring up interface with retries: always down before up
+bringup_interface() {
+    iface="$1"
+    retries="$2"
+    sleep_sec="$3"
+    i=0
+    while [ $i -lt "$retries" ]; do
+        if command -v ip >/dev/null 2>&1; then
+            ip link set "$iface" down
+            sleep 1
+            ip link set "$iface" up
+            sleep "$sleep_sec"
+            if ip link show "$iface" | grep -q "state UP"; then
+                return 0
+            fi
+        elif command -v ifconfig >/dev/null 2>&1; then
+            ifconfig "$iface" down
+            sleep 1
+            ifconfig "$iface" up
+            sleep "$sleep_sec"
+            if ifconfig "$iface" | grep -q "UP"; then
+                return 0
+            fi
+        fi
+        i=$((i + 1))
+    done
+    return 1
+}