Fix handling message errors

Author: Kewin Polok

src/errors/MessageResponseError/index.ts renamed to src/errors/MessageError/index.ts

@@ -2,6 +2,7 @@ import nock from 'nock';
 
 import { API_URL } from '../../constants';
 import { SMSAPI } from '../../smsapi';
+import { MessageErrorResponse } from '../../types';
 
 const smsapi = new SMSAPI('someToken');
 
@@ -96,4 +97,39 @@ describe('Base message module', () => {
     // then
     expect(req.isDone()).toBeTruthy();
   });
+
+  it('should throw error when sms.do returns one', async () => {
+    // given
+    const invalidNumber = '500000xxx';
+    const message = 'someMessage';
+    const errorResponse: MessageErrorResponse = {
+      error: 13,
+      message: 'No correct phone numbers',
+    };
+
+    const date = new Date();
+
+    const req = nock(API_URL)
+      .post('/sms.do', {
+        date: date.toISOString(),
+        date_validate: true,
+        details: true,
+        encoding: 'utf-8',
+        format: 'json',
+        message,
+        to: invalidNumber,
+      })
+      .reply(200, errorResponse);
+
+    // when
+    try {
+      await smsapi.sms.sendSms(invalidNumber, message, {
+        date,
+      });
+    } catch (error) {
+      expect(req.isDone()).toBeTruthy();
+
+      expect(error.data).toEqual(errorResponse);
+    }
+  });
 });

src/modules/baseMessageModule/index.spec.ts

@@ -12,7 +12,7 @@ import {
   MessageError,
   MessageErrorResponse,
   isMessageErrorResponseData,
-} from '../../errors/MessageResponseError';
+} from '../../errors/MessageError';
 
 import {
   MessageContent,

src/modules/baseMessageModule/index.ts

@@ -15,7 +15,7 @@ import { SubuserCredentials } from '../modules/subusers/types/SubuserCredentials
 import { SubuserPoints } from '../modules/subusers/types/SubuserPoints';
 import { Template } from '../modules/templates/types/Template';
 import { UpdateSubuser } from '../modules/subusers/types/UpdateSubuser';
-import { MessageErrorResponse } from '../errors/MessageResponseError';
+import { MessageErrorResponse } from '../errors/MessageError';
 
 import { MessageStatus } from './MessageStatus';
 import { MessageResponse } from './MessageResponse';