update axios & nock

Author: pdziewa

package.json

@@ -18,7 +18,7 @@
     "prepublishOnly": "yarn lint && yarn test"
   },
   "dependencies": {
-    "axios": "^0.21.1",
+    "axios": "^1.6.1",
     "form-data": "^4.0.0",
     "lodash": "^4.17.21"
   },
@@ -40,7 +40,7 @@
     "eslint-plugin-standard": "^5.0.0",
     "husky": "^8.0.3",
     "jest": "^29.6.1",
-    "nock": "^13.3.2",
+    "nock": "^13.3.8",
     "prettier": "^3.0.0",
     "rimraf": "^5.0.1",
     "tslib": "^2.6.0",

src/modules/contacts/httpClient/prepareParamsForRequest/index.spec.ts

@@ -59,7 +59,7 @@ describe('prepareParamsForRequest', () => {
     // given
     const contactParams: GetContactsQueryParams = {
       birthdayDate: [new Date('2015-07-13'), new Date('2015-07-15')],
-      email: 'someEmail',
+      email: ['someEmail1', 'someEmail2'],
       firstName: 'someFirstName',
       gender: 'female',
       groupId: 'someGroupId',
@@ -72,8 +72,8 @@ describe('prepareParamsForRequest', () => {
     };
 
     const body = {
-      birthday_date: ['2015-07-13', '2015-07-15'],
-      email: contactParams.email,
+      birthday_date: '2015-07-13,2015-07-15',
+      email: 'someEmail1,someEmail2',
       first_name: contactParams.firstName,
       gender: contactParams.gender,
       group_id: contactParams.groupId,

src/modules/contacts/httpClient/prepareParamsForRequest/index.ts

@@ -1,6 +1,6 @@
 import { stringify } from 'querystring';
 
-import { AxiosRequestConfig } from 'axios';
+import { InternalAxiosRequestConfig } from 'axios';
 import isArray from 'lodash/isArray';
 import mapKeys from 'lodash/mapKeys';
 import mapValues from 'lodash/mapValues';
@@ -15,20 +15,24 @@ const formatKeys = (data: Record<string, string | boolean | number>) => {
 };
 
 export const prepareParamsForRequest = (
-  config: AxiosRequestConfig,
-): AxiosRequestConfig => {
+  config: InternalAxiosRequestConfig,
+): InternalAxiosRequestConfig => {
   const { data, method, params } = config;
 
   if (['get', 'delete'].includes((method as string).toLowerCase())) {
     let formattedParams = mapValues(params, (value, key) => {
       if (key === 'birthdayDate') {
         if (isArray(value)) {
-          return value.map(formatDate);
+          return value.map(formatDate).join(',');
         }
 
         return formatDate(value);
       }
 
+      if (isArray(value)) {
+        return value.join(',');
+      }
+
       return value;
     });
 

src/smsapi/index.ts

@@ -1,7 +1,5 @@
 /* eslint-disable @typescript-eslint/ban-ts-comment */
 import axios, { AxiosInstance } from 'axios';
-// @ts-ignore TS7016
-import adapter from 'axios/lib/adapters/http';
 
 import { Contacts } from '../modules/contacts';
 import { Hlr } from '../modules/hlr';
@@ -56,7 +54,7 @@ export class SMSAPI {
 
   private setHttpClient(): AxiosInstance {
     const httpClient = axios.create({
-      adapter,
+      adapter: 'http',
       baseURL: API_URL,
       headers: {
         Accept: 'application/json',