Skip to content

Commit fe6bb7c

Browse files
nerdileysaito1001
andauthored
Fix private-in-public error in rustc before 1.74.0 (#3675)
## Motivation and Context Rustc 1.74.0 removed the private-in-public check, which raises a compile-time error if a member of a struct has a type which is less visible than the parent struct. Fixing this private-in-public issue enables aws-smithy-runtime to build in projects using rustc older than 1.74.0. ## Description Make UploadThroughputCheckFuture pub(crate) because it is needed in MaybeUploadThroughputCheckFuture which is pub(crate). ## Testing Verified that crate now compiles using rustc 1.72.1. ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: ysaito1001 <awsaito@amazon.com>
1 parent da2ffc5 commit fe6bb7c

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

CHANGELOG.next.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,9 @@ message = "Add support for v1 `http_body::Body` to `aws_smithy_types::byte_strea
2222
references = ["smithy-rs#1925", "smithy-rs#3673"]
2323
meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "all"}
2424
author = "Velfi"
25+
26+
[[smithy-rs]]
27+
message = "Enable aws-smithy-runtime to compile in rustc 1.72.1"
28+
references = ["smithy-rs#3675"]
29+
meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "client" }
30+
author = "dastrom"

rust-runtime/aws-smithy-runtime/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "aws-smithy-runtime"
3-
version = "1.5.5"
3+
version = "1.5.6"
44
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Zelda Hessler <zhessler@amazon.com>"]
55
description = "The new smithy runtime crate"
66
edition = "2021"

rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ impl UploadReport for ThroughputReport {
219219
pin_project_lite::pin_project! {
220220
/// Future that pairs with [`UploadThroughput`] to add a minimum throughput
221221
/// requirement to a request upload stream.
222-
struct UploadThroughputCheckFuture {
222+
pub(crate) struct UploadThroughputCheckFuture {
223223
#[pin]
224224
response: HttpConnectorFuture,
225225
#[pin]

0 commit comments

Comments
 (0)