You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Port fix for debug bound on ResolveEndpoint (#2636)
## Motivation and Context
Port #2630 to the `main`
branch.
## Description
Adding `Debug` bound on `ResolveEndpoint` in
#2577 was a breaking change.
Unfortunately, the semvar check that ran in that PR barked at a
different thing (i.e. barked at moving `StaticUriEndpointResolver` and
`DefaultEndpointResolver` from `aws-smithy-runtime-api` to
`aws-smithy-runtime`). Eventually the breaking change got merged to the
`main` branch.
This PR reverts the change in question and implements the `Debug` trait
for `ResolveEndpoint` in a semvar non-breaking way.
## Testing
- [ ] Passed tests in CI
----
_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
Co-authored-by: Yuki Saito <awsaito@amazon.com>
Copy file name to clipboardExpand all lines: codegen-client/src/main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/generators/config/ServiceConfigGenerator.kt
+14-1Lines changed: 14 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -228,12 +228,25 @@ class ServiceConfigGenerator(private val customizations: List<ConfigCustomizatio
228
228
}
229
229
230
230
writer.docs("Builder for creating a `Config`.")
231
-
writer.raw("#[derive(Clone, Debug, Default)]")
231
+
writer.raw("#[derive(Clone, Default)]")
232
232
writer.rustBlock("pub struct Builder") {
233
233
customizations.forEach {
234
234
it.section(ServiceConfig.BuilderStruct)(this)
235
235
}
236
236
}
237
+
238
+
// Custom implementation for Debug so we don't need to enforce Debug down the chain
239
+
writer.rustBlock("impl std::fmt::Debug for Builder") {
0 commit comments