Skip to content

Commit eb61ae3

Browse files
authored
Add aws-config to semver-checks deny list (#3267)
## Motivation and Context Skip running `semver-checks` on `aws-config` to enable clean runs for CI while #3265 is investigated. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
1 parent 167e3b5 commit eb61ae3

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

tools/ci-scripts/codegen-diff/semver-checks.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,16 @@ def main(skip_generation=False):
3636
failures = []
3737
deny_list = [
3838
# add crate names here to exclude them from the semver checks
39+
# TODO(https://github.com/smithy-lang/smithy-rs/issues/3265)
40+
'aws-config'
3941
]
4042
for path in list(os.listdir())[:10]:
4143
eprint(f'checking {path}...', end='')
42-
if path not in deny_list and get_cmd_status(f'git cat-file -e base:{sdk_directory}/{path}/Cargo.toml') == 0:
44+
if path in deny_list:
45+
eprint(f"skipping {path} because it is in 'deny_list'")
46+
elif get_cmd_status(f'git cat-file -e base:{sdk_directory}/{path}/Cargo.toml') != 0:
47+
eprint(f'skipping {path} because it does not exist in base')
48+
else:
4349
get_cmd_output('cargo generate-lockfile', quiet=True)
4450
(_, out, _) = get_cmd_output('cargo pkgid', cwd=path, quiet=True)
4551
pkgid = parse_package_id(out)
@@ -59,8 +65,6 @@ def main(skip_generation=False):
5965
if out:
6066
eprint(out)
6167
eprint(err)
62-
else:
63-
eprint(f'skipping {path} because it does not exist in base')
6468
if failures:
6569
eprint('One or more crates failed semver checks!')
6670
eprint("\n".join(failures))

0 commit comments

Comments
 (0)