Skip to content

Commit b589bd0

Browse files
ysaito1001jdisanti
authored andcommitted
Switch to rust-toolchain@master in "Update GitHub Pages" (#2613)
## Motivation and Context The previous attempt #2610 did not work for properly running the workflow for `Update GitHub Pages`. This PR reverts it and uses a different fix to address the issue. ## Description Possibly with [this](https://users.rust-lang.org/t/sparse-registry-breaking-my-ci-and-i-dont-understand-why/89976) and `dtolnaly/rust-toolchain` having fixed a couple of issues [related to the sparse registry](https://github.com/dtolnay/rust-toolchain/issues?q=is%3Aissue+is%3Aclosed+sparse) recently, this PR will use `dtolnaly/rust-toolchain@master` rather than `stable` (most CIs in this repository have been using `master`). ## Testing The workflow in question has been verified to run successfully with this change ([link](https://github.com/awslabs/smithy-rs/actions/runs/4758820036)). ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Yuki Saito <awsaito@amazon.com> Co-authored-by: John DiSanti <jdisanti@amazon.com>
1 parent 32115b4 commit b589bd0

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

.github/workflows/github-pages.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
on:
22
workflow_dispatch:
3-
inputs:
4-
opt-in-to-sparse-registry:
5-
description: Enable/disable CARGO_UNSTABLE_SPARSE_REGISTRY (https://blog.rust-lang.org/2022/06/22/sparse-registry-testing.html)
6-
required: true
7-
type: boolean
8-
default: false
93
push:
104
branches: [main]
115
paths:
126
- design/**
137

148
name: Update GitHub Pages
159

10+
env:
11+
rust_version: 1.67.1
12+
1613
# Allow only one doc pages build to run at a time for the entire smithy-rs repo
1714
concurrency:
1815
group: github-pages-yml
@@ -26,11 +23,12 @@ jobs:
2623
uses: actions/checkout@v3
2724
with:
2825
persist-credentials: false
29-
- uses: dtolnay/rust-toolchain@stable
26+
- uses: dtolnay/rust-toolchain@master
27+
with:
28+
toolchain: ${{ env.rust_version }}
3029
- name: Generate docs
3130
env:
3231
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
33-
CARGO_UNSTABLE_SPARSE_REGISTRY: ${{ inputs.opt-in-to-sparse-registry }}
3432
run: |
3533
git config --local user.name "AWS SDK Rust Bot"
3634
git config --local user.email "aws-sdk-rust-primary@amazon.com"

0 commit comments

Comments
 (0)