Some issues fixed for non-public constrained types

Author: Fahad Zubair

codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ConstrainedShapeSymbolProvider.kt

@@ -168,10 +168,15 @@ class ConstrainedShapeSymbolProvider(
         } else {
             // For List, Union and Map, the new shape defined for a constrained member shape
             // need to be placed into an inline module named `pub {container_name_in_snake_case}`
-            val innerModuleName = RustReservedWords.escapeIfNeeded(container.id.name.toSnakeCase())
+            val innerModuleName = RustReservedWords.escapeIfNeeded(container.id.name.toSnakeCase()) + if (pubCrateServerBuilder) {
+                    "_internal"
+            } else {
+                    ""
+            }
+
             val innerModule = RustModule.new(
                 innerModuleName,
-                visibility = if (pubCrateServerBuilder) Visibility.PUBLIC else Visibility.PUBCRATE,
+                visibility = Visibility.publicIf(!pubCrateServerBuilder, Visibility.PUBCRATE),
                 parent = defaultModule,
                 inline = true,
             )

codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/Constraints.kt

@@ -199,7 +199,7 @@ fun Shape.getParentAndInlineModuleForConstrainedMember(symbolProvider: SymbolPro
     else {
         // For constrained member shapes, the ConstraintViolation code needs to go in an inline rust module
         // that is a descendant of the module that contains the extracted shape itself.
-        if (!pubCrateServerBuilder) {
+        return if (!pubCrateServerBuilder) {
             // List, union and map types need to go into their own module
             val shapeSymbol = symbolProvider.toSymbol(this)
             val shapeModule = shapeSymbol.module()
@@ -209,18 +209,15 @@ fun Shape.getParentAndInlineModuleForConstrainedMember(symbolProvider: SymbolPro
             Pair(shapeModule.parent as RustModule.LeafModule, shapeModule)
         }
         else {
-            TODO()
+            val name = RustReservedWords.escapeIfNeeded(overriddenTrait.container.id.name).toSnakeCase() + "_internal"
+            val innerModule = RustModule.new(
+                    name = name,
+                    visibility = Visibility.PUBCRATE,
+                    parent = ModelsModule,
+                    inline = true,
+                )
+
+            Pair(ModelsModule, innerModule)
         }
-//        else {
-//            val name = RustReservedWords.escapeIfNeeded(overriddenTrait.container.contextName(serviceShape)).toSnakeCase()
-//            val innerModule = RustModule.new(
-//                    name = name,
-//                    visibility = Visibility.PUBCRATE,
-//                    parent = ModelsModule,
-//                    inline = true,
-//                )
-//
-//            Pair(ModelsModule, innerModule)
-//        }
     }
 }