Bump MSRV to 1.86 (#4191)

landonxjames · web-flow · commit a98b5b605adf · 2025-07-03T16:14:44.000Z
Bump MSRV to 1.86. Most changes are to fix indenting issues in doc
comments that clippy caught.


----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -33,7 +33,7 @@ on:
         required: false
 
 env:
-  rust_version: 1.85.0
+  rust_version: 1.86.0
   rust_toolchain_components: clippy,rustfmt
   ENCRYPTED_DOCKER_PASSWORD: ${{ secrets.ENCRYPTED_DOCKER_PASSWORD }}
   DOCKER_LOGIN_TOKEN_PASSPHRASE: ${{ secrets.DOCKER_LOGIN_TOKEN_PASSPHRASE }}
diff --git a/.github/workflows/claim-crate-names.yml b/.github/workflows/claim-crate-names.yml
@@ -10,7 +10,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  rust_version: 1.85.0
+  rust_version: 1.86.0
 
 name: Claim unpublished crate names on crates.io
 run-name: ${{ github.workflow }}
diff --git a/.github/workflows/github-pages.yml b/.github/workflows/github-pages.yml
@@ -8,7 +8,7 @@ on:
 name: Update GitHub Pages
 
 env:
-  rust_version: 1.85.0
+  rust_version: 1.86.0
 
 # Allow only one doc pages build to run at a time for the entire smithy-rs repo
 concurrency:
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -10,7 +10,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  rust_version: 1.85.0
+  rust_version: 1.86.0
 
 name: Release smithy-rs
 on:
diff --git a/.github/workflows/update-sdk-next.yml b/.github/workflows/update-sdk-next.yml
@@ -46,7 +46,7 @@ jobs:
     - name: Set up Rust
       uses: dtolnay/rust-toolchain@master
       with:
-        toolchain: 1.85.0
+        toolchain: 1.86.0
     - name: Delete old SDK
       run: |
     - name: Generate a fresh SDK
diff --git a/aws/rust-runtime/Cargo.lock b/aws/rust-runtime/Cargo.lock
diff --git a/aws/rust-runtime/aws-config/Cargo.lock b/aws/rust-runtime/aws-config/Cargo.lock
diff --git a/aws/rust-runtime/aws-config/Cargo.toml b/aws/rust-runtime/aws-config/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "aws-config"
-version = "1.8.1"
+version = "1.8.2"
 authors = [
     "AWS Rust SDK Team <aws-sdk-rust@amazon.com>",
     "Russell Cohen <rcoh@amazon.com>",
diff --git a/aws/rust-runtime/aws-config/src/ecs.rs b/aws/rust-runtime/aws-config/src/ecs.rs
@@ -23,11 +23,11 @@
 //! 2. The URL refers to an allowed IP address. If a URL contains a domain name instead of an IP address,
 //!    a DNS lookup will be performed. ALL resolved IP addresses MUST refer to an allowed IP address, or
 //!    the credentials provider will return `CredentialsError::InvalidConfiguration`. Valid IP addresses are:
-//!     a) Loopback interfaces
-//!     b) The [ECS Task Metadata V2](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-metadata-endpoint-v2.html)
-//!        address ie 169.254.170.2.
-//!     c) [EKS Pod Identity](https://docs.aws.amazon.com/eks/latest/userguide/pod-identities.html) addresses
-//!        ie 169.254.170.23 or fd00:ec2::23
+//!    a) Loopback interfaces
+//!    b) The [ECS Task Metadata V2](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-metadata-endpoint-v2.html)
+//!    address ie 169.254.170.2.
+//!    c) [EKS Pod Identity](https://docs.aws.amazon.com/eks/latest/userguide/pod-identities.html) addresses
+//!    ie 169.254.170.23 or fd00:ec2::23
 //!
 //! **Next**: It will check the value of `$AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE`. If this is set,
 //! the filename specified will be read, and the value passed in the `Authorization` header. If the file
diff --git a/aws/rust-runtime/aws-config/src/retry.rs b/aws/rust-runtime/aws-config/src/retry.rs
@@ -50,7 +50,7 @@ pub mod error {
                 InvalidRetryMode { .. } => {
                     write!(f, "invalid retry configuration")
                 }
-                MaxAttemptsMustNotBeZero { .. } => {
+                MaxAttemptsMustNotBeZero => {
                     write!(f, "invalid configuration: It is invalid to set max attempts to 0. Unset it or set it to an integer greater than or equal to one.")
                 }
                 FailedToParseMaxAttempts { .. } => {
@@ -66,7 +66,7 @@ pub mod error {
             match &self.kind {
                 InvalidRetryMode { source, .. } => Some(source),
                 FailedToParseMaxAttempts { source, .. } => Some(source),
-                MaxAttemptsMustNotBeZero { .. } => None,
+                MaxAttemptsMustNotBeZero => None,
             }
         }
     }
diff --git a/aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsFluentClientDecorator.kt b/aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsFluentClientDecorator.kt
@@ -136,9 +136,9 @@ private class AwsFluentClientExtensions(private val codegenContext: ClientCodege
                 /// ## Panics
                 ///
                 /// - This method will panic if the `sdk_config` is missing an async sleep implementation. If you experience this panic, set
-                ///     the `sleep_impl` on the Config passed into this function to fix it.
+                ///   the `sleep_impl` on the Config passed into this function to fix it.
                 /// - This method will panic if the `sdk_config` is missing an HTTP connector. If you experience this panic, set the
-                ///     `http_connector` on the Config passed into this function to fix it.
+                ///   `http_connector` on the Config passed into this function to fix it.
                 /// - This method will panic if no `BehaviorVersion` is provided. If you experience this panic, set `behavior_version` on the Config or enable the `behavior-version-latest` Cargo feature.
                 ##[track_caller]
                 pub fn new(sdk_config: &#{aws_types}::sdk_config::SdkConfig) -> Self {
diff --git a/gradle.properties b/gradle.properties
@@ -3,7 +3,7 @@
 # SPDX-License-Identifier: Apache-2.0
 #
 # Rust MSRV (entered into the generated README)
-rust.msrv=1.85.0
+rust.msrv=1.86.0
 # To enable debug, swap out the two lines below.
 # When changing this value, be sure to run `./gradlew --stop` to kill the Gradle daemon.
 # org.gradle.jvmargs=-Xmx1024M -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=localhost:5006
diff --git a/rust-runtime/Cargo.lock b/rust-runtime/Cargo.lock
diff --git a/rust-runtime/aws-smithy-runtime-api/Cargo.toml b/rust-runtime/aws-smithy-runtime-api/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "aws-smithy-runtime-api"
-version = "1.8.1"
+version = "1.8.2"
 authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Zelda Hessler <zhessler@amazon.com>"]
 description = "Smithy runtime types."
 edition = "2021"
diff --git a/rust-runtime/aws-smithy-runtime-api/src/client/retries/classifiers.rs b/rust-runtime/aws-smithy-runtime-api/src/client/retries/classifiers.rs
@@ -16,10 +16,10 @@
 //! with a lower priority. The intention is that:
 //!
 //! 1. Generic classifiers that look at things like the HTTP error code run
-//!     first.
+//!    first.
 //! 2. More specific classifiers such as ones that check for certain error
-//!     messages are run **after** the generic classifiers. This gives them the
-//!     ability to override the actions set by the generic retry classifiers.
+//!    messages are run **after** the generic classifiers. This gives them the
+//!    ability to override the actions set by the generic retry classifiers.
 //!
 //! Put another way:
 //!
diff --git a/rust-toolchain.toml b/rust-toolchain.toml
@@ -1,2 +1,2 @@
 [toolchain]
-channel = "1.85.0"
+channel = "1.86.0"
diff --git a/tools/ci-build/Dockerfile b/tools/ci-build/Dockerfile
@@ -6,7 +6,7 @@
 # This is the base Docker build image used by CI
 
 ARG base_image=public.ecr.aws/amazonlinux/amazonlinux:2023
-ARG rust_stable_version=1.85.0
+ARG rust_stable_version=1.86.0
 ARG rust_nightly_version=nightly-2025-05-04
 
 FROM ${base_image} AS bare_base_image
@@ -128,7 +128,7 @@ ARG wasm_pack_version=0.13.1
 RUN cargo install wasm-pack --locked --version ${wasm_pack_version}
 
 FROM install_rust AS wasmtime
-ARG cargo_wasmtime_version=28.0.0
+ARG cargo_wasmtime_version=34.0.1
 ARG rust_nightly_version
 RUN cargo install wasmtime-cli --features="component-model" --locked --version ${cargo_wasmtime_version}
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ pub mod error {`
`50`	`50`	`InvalidRetryMode { .. } => {`
`51`	`51`	`write!(f, "invalid retry configuration")`
`52`	`52`	`}`
`53`		`- MaxAttemptsMustNotBeZero { .. } => {`
	`53`	`+ MaxAttemptsMustNotBeZero => {`
`54`	`54`	`write!(f, "invalid configuration: It is invalid to set max attempts to 0. Unset it or set it to an integer greater than or equal to one.")`
`55`	`55`	`}`
`56`	`56`	`FailedToParseMaxAttempts { .. } => {`
`@@ -66,7 +66,7 @@ pub mod error {`
`66`	`66`	`match &self.kind {`
`67`	`67`	`InvalidRetryMode { source, .. } => Some(source),`
`68`	`68`	`FailedToParseMaxAttempts { source, .. } => Some(source),`
`69`		`- MaxAttemptsMustNotBeZero { .. } => None,`
	`69`	`+ MaxAttemptsMustNotBeZero => None,`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`	`}`