Skip to content

Commit a4337e2

Browse files
authored
Fix release issues (#3549)
This PR fixes to issues with the release: 1. One of the DynamoDB tests was failing due to environment variables impacting its behavior. 2. The stalled stream protection changelog entries were added in error via merge conflict. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
1 parent 16e404e commit a4337e2

File tree

3 files changed

+6
-24
lines changed

3 files changed

+6
-24
lines changed

CHANGELOG.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,9 @@ April 2nd, 2024
55
- :bug::warning: (client, [aws-sdk-rust#1111](https://github.com/awslabs/aws-sdk-rust/issues/1111), [smithy-rs#3513](https://github.com/smithy-lang/smithy-rs/issues/3513), @Ten0) Make `BehaviorVersion` be future-proof by disallowing it to be constructed via the `BehaviorVersion {}` syntax.
66

77
**New this release:**
8-
- :tada: (all, [smithy-rs#3485](https://github.com/smithy-lang/smithy-rs/issues/3485)) Stalled stream protection now supports request upload streams. It is currently off by default, but will be enabled by default in a future release. To enable it now, you can do the following:
9-
10-
```rust
11-
let config = my_service::Config::builder()
12-
.stalled_stream_protection(StalledStreamProtectionConfig::enabled().build())
13-
// ...
14-
.build();
15-
```
168
- :tada: (all, [smithy-rs#3539](https://github.com/smithy-lang/smithy-rs/issues/3539)) Add FIPS support to our Hyper 1.0-based client. Customers can enable this mode by enabling the `crypto-aws-lc-fips` on `aws-smithy-experimental`. To construct a client using the new client, consult this [example](https://github.com/awslabs/aws-sdk-rust/blob/release-2024-03-29/sdk/s3/tests/hyper-10.rs).
179

1810
Please note that support for Hyper 1.0 remains experimental.
19-
- :bug: (all, [smithy-rs#3485](https://github.com/smithy-lang/smithy-rs/issues/3485)) Stalled stream protection on downloads will now only trigger if the upstream source is too slow. Previously, stalled stream protection could be erroneously triggered if the user was slowly consuming the stream slower than the minimum speed limit.
2011
- (all, [smithy-rs#3389](https://github.com/smithy-lang/smithy-rs/issues/3389)) All requests are now retryable, even if they are deserialized successfully. Previously, this was not allowed.
2112
- (all, [smithy-rs#3539](https://github.com/smithy-lang/smithy-rs/issues/3539)) Fix bug in Hyper 1.0 support where https URLs returned an error
2213

aws/SDK_CHANGELOG.next.json

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -283,20 +283,6 @@
283283
"since-commit": "f19a9da9b8f79a7c448246475539c03e1bb58d7e",
284284
"age": 1
285285
},
286-
{
287-
"message": "Stalled stream protection now supports request upload streams. It is currently off by default, but will be enabled by default in a future release. To enable it now, you can do the following:\n\n```rust\nlet config = aws_config::defaults(BehaviorVersion::latest())\n .stalled_stream_protection(StalledStreamProtectionConfig::enabled().build())\n .load()\n .await;\n```\n",
288-
"meta": {
289-
"bug": false,
290-
"breaking": false,
291-
"tada": true
292-
},
293-
"author": "jdisanti",
294-
"references": [
295-
"smithy-rs#3485"
296-
],
297-
"since-commit": "f19a9da9b8f79a7c448246475539c03e1bb58d7e",
298-
"age": 1
299-
},
300286
{
301287
"message": "Users may now set service-specific configuration in the environment. For more information, see [this discussion topic](https://github.com/smithy-lang/smithy-rs/discussions/3537).",
302288
"meta": {
@@ -341,4 +327,4 @@
341327
}
342328
],
343329
"aws-sdk-model": []
344-
}
330+
}

aws/sdk/integration-tests/dynamodb/tests/shared-config.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ use aws_sdk_dynamodb::config::{
99
};
1010
use aws_smithy_runtime::client::http::test_util::capture_request;
1111
use http::Uri;
12+
use std::env;
1213

1314
/// Iterative test of loading clients from shared configuration
1415
#[tokio::test]
@@ -35,6 +36,10 @@ async fn shared_config_testbed() {
3536
async fn service_config_from_profile() {
3637
let _ = tracing_subscriber::fmt::try_init();
3738

39+
// Remove env vars that could interfere with the test
40+
env::remove_var("AWS_DEFAULT_REGION");
41+
env::remove_var("AWS_REGION");
42+
3843
let config = r#"
3944
[profile custom]
4045
aws_access_key_id = test-access-key-id

0 commit comments

Comments
 (0)