Use asValue instead of asRef. Do not use let _v if clippy gives a warning.

Author: Fahad Zubair

codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/parse/CborParserGenerator.kt

@@ -109,7 +109,7 @@ class CborParserGenerator(
                     """
                     let value = match decoder.datatype()? {
                         #{SmithyCbor}::data::Type::Null => {
-                            let _v = decoder.null()?;
+                            decoder.null()?;
                             None
                         }
                         _ => Some(#{DeserializeMember:W}?),
@@ -167,7 +167,7 @@ class CborParserGenerator(
                     """
                     let value = match decoder.datatype()? {
                         #{SmithyCbor}::data::Type::Null => {
-                            let _v = decoder.null()?;
+                            decoder.null()?;
                             None
                         }
                         _ => Some(#{DeserializeValue:W}?),

codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/serialize/CborSerializerGenerator.kt

@@ -402,7 +402,7 @@ class CborSerializerGenerator(
         rust(
             """
             encoder.array(
-                (${context.valueExpression.asRef()}).len().try_into().expect("`usize` to `u64` conversion failed")
+                (${context.valueExpression.asValue()}).len().try_into().expect("`usize` to `u64` conversion failed")
             );
             """
         )
@@ -421,7 +421,7 @@ class CborSerializerGenerator(
         rust(
             """
             encoder.map(
-                (${context.valueExpression.asRef()}).len().try_into().expect("`usize` to `u64` conversion failed")
+                (${context.valueExpression.asValue()}).len().try_into().expect("`usize` to `u64` conversion failed")
             );
             """
         )

rust-runtime/aws-smithy-cbor/src/decode.rs

@@ -17,6 +17,8 @@ pub struct Decoder<'b> {
     decoder: minicbor::Decoder<'b>,
 }
 
+/// When any of the decode methods are called they look for that particular data type at the current
+/// position. If the CBOR data tag does not match the type, a `DeserializeError` is returned.
 #[derive(Debug)]
 pub struct DeserializeError {
     #[allow(dead_code)]